Yarn: Registry.STRUCTURE_PIECE -> Registry.STRUCTURE_PIECE_TYPE
Registry.STRUCTURE_PIECE wants a StructurePieceType, which is a factory for creating StructurePieces. The name should be changed to STRUCTURE_PIECE_TYPE to reflect this (as is the case with the BlockEntityType/EntityType registries).
Draylar
All 6 comments
What is the name of the registry in the registry of registries? Probably structure_piece, in which case the name should remain.
JamiesWhiteShirt
on 20 Oct 2019
Is that because changing to STRUCTURE_PIECE_TYPE would require changing structure_piece to structure_piece_type, which would mess things up?
edit: and yes, it is structure_piece in the registry
Draylar
on 20 Oct 2019
I don't think the names in registry are auto. So yes, we can do this change. Will mark this for a vote.
liach
on 22 Oct 2019
Well, structure_piece in the registry registry are hardcoded strings from mojang, iirc. I say we keep to Registry.STRUCTURE_PIECE since that's the standard for anything registered.
Boundarybreaker
on 22 Oct 2019
fyi we already named the thing in the registry structure piece type.
liach
on 22 Oct 2019
The result of this vote seems conclusive
valoeghese
on 8 Nov 2019
Related issues
Sollace
路
5Comments
liach
路
4Comments
copygirl
路
6Comments
Runemoro
路
4Comments
enbrain
路
4Comments
Most helpful comment
Well,
structure_piecein the registry registry are hardcoded strings from mojang, iirc. I say we keep toRegistry.STRUCTURE_PIECEsince that's the standard for anything registered.