Yarn: "does this have that tag" methods have very different names

[quat1024]

As of Yarn 1.15+build.1, Item#isIn, Fluid#matches, EntityType#isTaggedWith, and Block#matches all have pretty much the same implementation - return tag.contains(this) - but have very different names. These all basically do the same thing so they should be unified to have the same name.

[liach]

I support isIn.

[Juuxel]

See also this: https://github.com/FabricMC/yarn/pull/712#discussion_r287569335

[YanisBft]

Additionnally, the method for entities should not be called isTaggedWith, as it seems it returns what the Tags nbt contains, instead of datapack tags

[Prospector]

I like matches personally

[liach]

it would have been tag.matches(item) than item.matches(tag)

[Prospector]

item.within(tag)
item.has(tag)
item.taggedWith(tag)

[liach]

within can be just is in, being in a tag isn't an intrinsic property of an item so has is inaccurate, and taggedWith is too long and isn't intrinsic either

[YanisBft]

I think isIn is the more accurate one