Yarn: ItemCooldownManager#isCooldown(ItemStack) dosen't make sense

Created on 20 Feb 2019  路  2Comments  路  Source: FabricMC/yarn

As it says in the title, isCooldown doesn't convey what the method does very well (it returns true if the stack has an active cooldown). hasCooldown or similar would be more appropriate and improve readability.

picture raphydaphy

Most helpful comment

Why not ItemCooldownManager#isActive()?

To me that would mean that the item isn't cooling down.

Why not just isCoolingDown?

picture Runemoro on 17 Mar 2019
👍2

All 2 comments

Why not ItemCooldownManager#isActive()?

asiekierka picture asiekierka on 23 Feb 2019
👍1

Why not ItemCooldownManager#isActive()?

To me that would mean that the item isn't cooling down.

Why not just isCoolingDown?

Runemoro picture Runemoro on 17 Mar 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

copygirl picture copygirl  路  6Comments
Runemoro picture Runemoro  路  3Comments
quat1024 picture quat1024  路  6Comments
quat1024 picture quat1024  路  3Comments
Juuxel picture Juuxel  路  5Comments