Xud: SubscribeAddedOrders response missing `side` field for buy orders

[reliveyy]

[kilrau]

@rsercano ?

[rsercano]

Hopefully this Saturday I'll check both issues @kilrau sorry for the delay

[rsercano]

This is strange because it seems like the side field is set everytime, even in cases that sell/buy state of the order is not clear (if it's not buy then it's automatically setting SELL); check here

Are you sure this bug still exist with the current master ?

[sangaman]

Where is the output in the original post from? It does seem like we always set a side, for both buys and sells. I'm wondering if the issue is that since the value for BUY is 0, and if you do something like if (side) then it may treat 0 as false.

[rsercano]

Great point @sangaman will investigate a bit further

[rsercano]

No luck ! Can you please tell us how to reproduce this ? @reliveyy

[reliveyy]

@rsercano Please check my testing code and uncomment two print lines. And this is reproduced on gcloud exchange-b.

[rsercano]

@reliveyy yeah now I reproduced it, you're right this seems a bit tricky can be related with streaming zero will try with another value.

[rsercano]

Hello again, seems like our streaming is working properly, somehow generated enum in python doesn't print properly so that's nothing to do with the core code.

I'm not really familiar with python, but if you make it write response.side it prints properly 0 or 1 for the corresponding value.

I guess this issue can be closed.

[reliveyy]

Just confirmed it's my python code printing issue. @rsercano

[kilrau]

Good job catching this one! @rsercano