Xbmc: [v18] Empty default="" values in rating tag will crash Kodi when scanning

[Borromini]

I first reported this issue on the forum, but was asked to file it here as well.

A scan of my series library would trigger a Kodi crash - crashlog is here and the offending .NFO content here. It turns out an .NFO containing <rating default="" max="10" name="thetvdb"> would crash Kodi. The .NFO files were produced by SickGear (related bug here).

Replacing default="" with default="true" (or false) will make Kodi happily scan my whole library as if nothing happened.

Debuglog

• Debug log here (same as above)
• NFO contents here (same as above)

Your Environment

Used Operating system:

• [ ] Android
• [ ] iOS
• [x] Linux
• [ ] OSX
• [ ] Raspberry-Pi
• [ ] Windows
• [ ] Windows UWP

• Operating system version/name: LibreELEC 9.2.0
• Kodi version: 18.5

[xbmc-gh-bot[bot]]

Thank you for using Kodi and our issue tracker. This is your friendly Kodi GitHub bot :wink:

It seems that you have not followed the template we provide and require for all bug reports (or have opened a roadmap item by accident). Please understand that following the template is mandatory and required for the team to be able handle the volume of open issues efficiently.

Please edit your issue message to follow our template and make sure to fill in all fields appropriately. The issue will be closed after one week has passed without satisfactory follow-up from your side.

This is an automatically generated message. If you believe it was sent in error, please say so and a team member will remove the "Ignored rules" label.

[Borromini]

Hi,

The report contains everything necessary - problem & solution.

Thanks

B

-------- Oorspronkelijk bericht --------
Aan 14 jan. 2020 22:20, xbmc-gh-bot[bot] schreef:

Thank you for using Kodi and our issue tracker. This is your friendly Kodi GitHub bot 😉

It seems that you have not followed the template we provide and require for all bug reports (or have opened a roadmap item by accident). Please understand that following the template is mandatory and required for the team to be able handle the volume of open issues efficiently.

Please edit your issue message to follow our template and make sure to fill in all fields appropriately. The issue will be closed after one week has passed without satisfactory follow-up from your side.

This is an automatically generated message. If you believe it was sent in error, please say so and a team member will remove the "Ignored rules" label.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[KarellenX]

Thank you @Borromini

There have been further reports here... https://github.com/SickGear/SickGear/issues/1162#issuecomment-573330382 by @JackDandy

[JackDandy]

It turns out a malformed .NFO (containing )

malformed is not correct given that the pattern default="" is documented here in the Kodi wiki. The issue was first discovered 4th Jan on OSMC, and SickGear found it too - I blame the docs :p

Kodi wiki NFO_files guidance...

@KarellenX The links I forwarded indicate code in Kodi core that _may_ be the cause of the crashing when it reads the .nfo text file, and the issue only seems to happen with particular configurations.

[Borromini]

@JackDandy There was no judgement in that 😄

[JackDandy]

@Borromini

Gotchya. I added clarity because the word malformed _can_ be read to place responsibility. Anyway, SickGear released handling for this issue 2 days ago. On application update, as a one time process, all .nfo files are scanned and changed where required.

[KarellenX]

@JackDandy

I have updated the wiki, hopefully removing the ambiguity.
https://kodi.wiki/view/NFO_files/TV_shows