Wp-rocket: PHP Notice: Missing permissions_callback triggered by doing_it_wrong in WP 5.5

[Davidacu]

Before submitting an issue please check that you’ve completed the following steps:

• Made sure you’re on the latest version 👍
• Used the search feature to ensure that the bug hasn’t been reported before 👍

Describe the bug
After updating to WP 5.5, whenever you open a page for edit or try to create a new post/page a PHP notice is displayed

Preconditions:

1. WP Rocket is activated.
2. Site is running WP 5.5

To Reproduce
Steps to reproduce the behavior:

1. Go to the Admin dashboard and click "All pages"
2. Click on "Add New" button

Expected behavior
The post editor is displayed.

Actual Behavior
The post editor is displayed, but a notice flash for a second, the error is also written to the debug log:
http://snippi.com/s/ekrsai6

Screenshots

Backlog Grooming (for WP Media dev team use only)

• [x] Reproduce the problem
• [x] Identify the root cause
• [x] Scope a solution
• [x] Estimate the effort

[iCaspar]

✔️ Reproduced locally.
✔️ Root cause is lack of a permissions_callback item in our route registrations array is now triggering a doing_it_wrong notice as of WP 5.5
✔️ Solution:

• [ ] Add the permissions_callback to the arrays in RESTSubscriber.php (These are public routes so we can use __return_true())
• [ ] Update the integration tests that will fail without having the permissions_callback defined in the API tests' REST routes.

✔️ Estimated effort: [s]

[JohnTorvik]

Related: https://secure.helpscout.net/conversation/1252680783/186408/

[piotrbak]

Related:
https://secure.helpscout.net/conversation/1252157227/186256/
https://secure.helpscout.net/conversation/1252385189/186334/

[viobru]

Related: https://secure.helpscout.net/conversation/1252869153/186451?folderId=3051575

[vmanthos]

Related ticket: https://secure.helpscout.net/conversation/1252912621/186459/

[JohnTorvik]

Related: https://secure.helpscout.net/conversation/1253200773/186532/
https://secure.helpscout.net/conversation/1253219871/186536/

[webtrainingwheels]

https://secure.helpscout.net/conversation/1253374564/186587?folderId=377611
https://secure.helpscout.net/conversation/1253396640/186592?folderId=377611

[piotrbak]

https://secure.helpscout.net/conversation/1253534119/186627/
https://secure.helpscout.net/conversation/1253567489/186631?folderId=2415573
https://secure.helpscout.net/conversation/1253636156/186652?folderId=273766
https://secure.helpscout.net/conversation/1253781523/186677

[DahmaniAdame]

https://secure.helpscout.net/conversation/1254304492/186787/

[NataliaDrause]

https://secure.helpscout.net/conversation/1255756294/187141

[iCaspar]

Hey folks, we cherry picked and rolled this change into yesterday's 3.6.4 hotfix, so 🤞 we won't be seeing any more of these.

We did, however, notice that WooCommerce 4.4.0 has the same issue, so customers may still report that they are getting the error.

In those cases, please check the notice itself if you get any new ones. If it's us, there will always be a line similar to line 10 in the above screenshot of an error stack trace with WP_Rocket\CDN\RocketCDN/RESTSubscriber->.

The WooCommerce 4.4.0 error will have a line like this one instead:

[18-Aug-2020 17:06:32 UTC] PHP  10. Automattic\WooCommerce\Blocks\RestApi::register_rest_routes() /Users/caspar/Local Sites/rocket/app/public/wp-includes/class-wp-hook.php:287