Wp-calypso: Nav Unification: How to sync with Jetpack release process?

[cpapazoglou]

Since we are planning in shipping the backend code in Jetpack, we need to align with the Jetpack Release dates so that the feature lands on Atomic sites the same time as it lands on wpcom.

The Jetpack release will happen on December 1st. As a general rule of thumb, you may expect a Jetpack release on the first Tuesday of each month. Code freeze and first Beta is one week before the release date, on the last Tuesday of the month.

Scheduled Releases
9.2 | 9.3
-------|------
Code Freeze on 2020-11-23|Code Freeze on 2021-01-04
Beta Release on 2020-11-24|Beta Release on 2021-01-05
Release on 2020-12-01|Release on 2021-01-12

Let's make sure that we have aligned with Jetpack and we have prepared everything they need for a release.

[cpapazoglou]

@obenland, @jeherve could please chime in case you have something to add?

[obenland]

The endpoint is already in and available to us. The work in https://github.com/Automattic/jetpack/pull/17629 is currently behind a filter and conditional that only activates it on simple sites and atomic. It also requires the masterbar module to be active.
We can use that filter to set visibility of the feature from wpcomsh.

[cpapazoglou]

So you are suggesting releasing now (before Nov 23) all the changes we need and handling this feature visibility / availability from an other plugin _wpcomsh_ which can be released as we please. I assume we should be deploying this toggle in wpcom too right?

[obenland]

Yup, that's right!

[cpapazoglou]

@obenland Let's target Code Freeze on 2020-11-23 for having in Jetpack the most stable solution dependant on a filter https://github.com/Automattic/jetpack/pull/17629

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

[frontdevde]

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

Calypso Color Schemes maybe should we we decide they will live in Jetpack. Could either be also be filtered so it only shows on Simple or Atomic, or maybe Jetpack would be interested to provide other Jetpack folks with those Color Schemes as well as a feature. Working on the color scheme generation in this draft PR https://github.com/Automattic/jetpack/pull/17828.

[cpapazoglou]

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

Calypso Color Schemes maybe should we we decide they will live in Jetpack. Could either be also be filtered so it only shows on Simple or Atomic, or maybe Jetpack would be interested to provide other Jetpack folks with those Color Schemes as well as a feature. Working on the color scheme generation in this draft PR Automattic/jetpack#17828.

IIRC, we are going to enable this feature (hiding scheme selection, more color-schemes) to simple & atomic customers only - not self hosted. So, yes it needs to be filtered too (by the same exact filter).

[obenland]

by the same exact filter

Filters are cheap, feel free create a context-specific filter for this

[cpapazoglou]

by the same exact filter

Filters are cheap, feel free create a context-specific filter for this

That's true. I totally forgot that we have decoupled color-schemes from nav-unification! Thanks for chiming in @obenland !

[frontdevde]

IIRC, we are going to enable this feature (hiding scheme selection, more color-schemes) to simple & atomic customers only - not self hosted. So, yes it needs to be filtered too (by the same exact filter).

The "hiding scheme selection" portion should definitely be limited to Simple & WoA customers.

Initially, the "more color-schemes" portion as well. That said, this portion by itself might be interesting to Jetpack as a feature i.e. adding more color schemes to wp-admin. Providing additional wp-admin color schemes to all Jetpack users might be a nice value add, especially as it's "for free" in terms of development overhead for the Jetpack team as we're working on it (and it needs to be maintained in the future for wpcom anyway).

Just thinking out loud here though, uncertain of what Jetpack wants. Maybe @jeherve has thoughts on this?

Filters are cheap, feel free create a context-specific filter for this

Sounds good 👍

[jeherve]

Providing additional wp-admin color schemes to all Jetpack users might be a nice value add, especially as it's "for free" in terms of development overhead for the Jetpack team as we're working on it (and it needs to be maintained in the future for wpcom anyway).

Yeah, I think that makes perfect sense. I don't see any reason to not offer this to Jetpack users, as long as, like you mentioned, we do not hide the scheme selection by default, and as long as everything we do can be disabled with a filter.

[jeherve]

@obenland @frontdevde @getdave Do y'all have a list of things that should be in before Monday evening?

https://github.com/Automattic/jetpack/pull/17833
https://github.com/Automattic/jetpack/pull/17629
https://github.com/Automattic/jetpack/pull/17828

Is there anything else I am missing?

@pablinos Would https://github.com/Automattic/jetpack/pull/17826 qualify as part of that project? Would you want this in 9.1?

Thank you all!

cc @anomiex who's leading the release this time around.

[obenland]

Automattic/jetpack#17833 would be helpful, yes.

Automattic/jetpack#17629: I wouldn't be heartbroken about it if it didn't get in. We just fixed another bug in it and it needs follow-up work anyway.
Automattic/jetpack#17828 looks like it might not be ready in time

[frontdevde]

Automattic/jetpack#17828 won't be ready for 9.2, we're aiming for the 9.3 release.
We discussed this in our Backlog Grooming meeting, I should've added a note here as well.