There are two usages of font-size: 10px
in Gutenboarding at the moment:
So i'd like to propose an update for the scales/font-size
rule and typography variables.
cc: @sixhours
I think we should update designs instead to adopt next closest font size if possible. Cc @olaolusoga
馃憢 Thanks for the ping!
Do you have visual examples of the copy in action? 10px is usually very tiny, and I think we should avoid tiny fonts for better accessibility and readability.
If we absolutely can't make the font size larger (I think 12px is the next closest size) then adding exceptions (as you've done) is the way to go, rather than adding a tiny font size to the scale, which would encourage its use.
But I'm open to your thoughts!
Here are screenshots with the exceptions:
I agree with keeping them as exceptions or even extracting to a Tag
component which could become the only exception.
@ollierozdarz what do you think?
@razvanpapadopol I'm fine with either solution. I think 10px when in uppercase looks better in these type of tag/label scenarios, but it's quite a fine detail, so not worth the extra work if it's a pain.
Ok, so there is a good reason to keep them as exceptions. Thanks for your input!
Closing this issue for now.
Most helpful comment
@razvanpapadopol I'm fine with either solution. I think 10px when in uppercase looks better in these type of tag/label scenarios, but it's quite a fine detail, so not worth the extra work if it's a pain.