Wp-calypso: (3P) Add optional prop to implement a celebratory image to "Site Creation" checklist step

Created on 7 Jul 2020  路  3Comments  路  Source: Automattic/wp-calypso

Based on comment here let's add a celebratory image to the checklist step for "Site Created".

@danhauk can confirm design. Or possibly @jancavan?

Would it make sense to add an image to this step to bump up the celebratory nature little bit up?

@simison Quite possibly. Seems like a good suggestion. Currently, I'm working to this design by @danhauk. If we want/need to add this then it should probably be in a followup PR.

If @danhauk agrees then I'm happy to raise a separate Issue.

_Originally posted by @getdave in https://github.com/Automattic/wp-calypso/pull/43861#issuecomment-654730148_

Update:
We can add an optional prop that can receive a component so the fireworks image (or whatever else) can be added here.

[Type] Enhancement

Most helpful comment

I agree. When this is picked up, could we make the task component have an optional image prop? I'm thinking of an additional use case would be as a video placeholder to open a support doc in a modal (something I was exploring previously as a future enhancement):

image

All 3 comments

Yes, I agree that this one card could be a little bit more celebratory. We can add the illustration back like so:

Screen Shot 2020-07-08 at 9 01 49 AM

I feel like the dark gray pill is a little too close to the heading. I think we should move it down a bit? @getdave @danhauk

I agree. When this is picked up, could we make the task component have an optional image prop? I'm thinking of an additional use case would be as a video placeholder to open a support doc in a modal (something I was exploring previously as a future enhancement):

image

@getdave I updated the mockup above. I think the illustration can be made slightly bigger. Thanks.

Was this page helpful?
0 / 5 - 0 ratings