Wp-calypso: Missing Block Inserter in dotcom FSE w/ Gutenberg 8.4
Dotcom FSE sites running on Gutenberg v 8.4 are missing their inserter:
Expected (as seen on v8.3):
This seems to be an issue with the Inserter implementation in post-content-block-appender:
Addison-Stavlo
All 7 comments
I checked 8.5.0-alpha.1 and 8.5.0 and couldn't reproduce this issue in neither.
alshakero
on 13 Jul 2020
Hrm, I am still noticing it on the 8.5.1 on edge stickered sites. Are you checking a dotcom FSE enabled site @alshakero (not just a dotcom site running the FSE plugin) ? Its the deprecated project that requires a specific blog sticker full-site-editing and supporting theme (such as Maywood) to be active.
Addison-Stavlo
on 14 Jul 2020
Oh I didn't know this. That's probably why I didn't see it.
alshakero
on 15 Jul 2020
You can test "dotcom-FSE" by creating a site through this link: https://horizon.wordpress.com/start/test-fse, and then loading the page editor (not post editor)
It still has a few users on it, so it is still on the list to be checked to make sure it works. It's fragile, which is both why we are working core-first now, _and_ why we still have to check it 😅 But it will likely eventually be migrated to core FSE once we get there.
noahtallen
on 21 Jul 2020
The top inserter is removed from the post (not _page_/FSE) editor as well, which is another issue and a quick fix. I'll have that in a PR soon.
sirreal
on 22 Jul 2020
The inserter is rendered and inserted fine. The issue is that something appears to cause the header to rerender. When the header rerenders, the element is gone — it's not part of the React tree.
This was a volatile solution to begin with and we're hitting an expected issue.
If you add a debugger statement after this line you can see the inserter is clearly inserted:
https://github.com/Automattic/wp-calypso/blob/4f23e86f849c96ea6567be6cac2ba1afa16a5d30/apps/full-site-editing/full-site-editing-plugin/dotcom-fse/editor/block-inserter/index.js#L35
sirreal
on 22 Jul 2020
Proposed fix/workaround for these issues: #44357
sirreal
on 22 Jul 2020
Related issues
ehg
·
3Comments
jeherve
·
3Comments
ghost
·
3Comments
lamosty
·
3Comments
rickybanister
·
3Comments
Most helpful comment
The inserter is rendered and inserted fine. The issue is that something appears to cause the header to rerender. When the header rerenders, the element is gone — it's not part of the React tree.
This was a volatile solution to begin with and we're hitting an expected issue.
If you add a debugger statement after this line you can see the inserter is clearly inserted:
https://github.com/Automattic/wp-calypso/blob/4f23e86f849c96ea6567be6cac2ba1afa16a5d30/apps/full-site-editing/full-site-editing-plugin/dotcom-fse/editor/block-inserter/index.js#L35