Wp-calypso: Activity Log: WP Admin Editor theme edits aren't recorded

[anaemnesis]

According to Jetpack's Activity Log support page (https://jetpack.com/support/activity-log/), the Activity Log will record:

• Themes: installations, edits, deletions, switches, network enable/disable actions

However, we have a user in 3094557-zen who is reporting that theme _edits_ are, in fact, _not_ recorded.

To replicate:

1. Log into WP Admin, and navigate to Appearance --> Editor
2. Pick any file from a theme, and make edits to it. I have test with JS, CSS and PHP assets
3. Force a fresh sync of the site's data via Jetpack Debugger
4. Navigate to the Activity Log for the site in question from WordPress.com, via My Sites --> Tools --> Activity Log
5. Ensure that no filter, or the correct filter is applied
6. There is no theme edit activity

Expected result, according to the documentation:

Theme edits will show in the Activity Log alongside a backup point

I also tested with edits to theme options via the Customizer, and those aren't showing either. So I'm reporting as a bug for now, but I suspect there's ambiguity in the documentation and 'edit' might not mean edits to theme files.

[StefMattana]

I bumped @brucea8c ping in Slack again to see if someone can take a look at this of us.

[mattgawarecki]

I'm checking on this issue today with a couple of teams that work with the Activity Log -- will report back with updates.

[mattgawarecki]

Early investigation is showing that jetpack_edited_theme events aren't being recorded correctly, which would cause the reported behavior. Discussion about who specifically will address the issue is ongoing, but this definitely looks like a back-end issue.

I'm cc'ing @vianasw here, who may be able to provide more info as investigations continue.

[mzakariya]

Any updates on this @mattgawarecki or @vianasw? Thanks! :)

[vianasw]

Sorry for the delay. I've found a bug that is preventing the event from reaching the Activity Log, and I've created a patch here:
https://code.a8c.com/D47418

However, that's not all. The UI for the _theme modified_ event seems a bit off (I guess it should be similar to the plugin edited event, see picture below):

And it's not triggering a backup but neither is the _plugin modified_ event, so I'm starting to doubt if it should. I'll keep digging, but I guess someone from Voyager should take a look at the UI issue for the _theme modified_ event.

[anaemnesis]

Pinging @Automattic/jetpack-voyager per the comment above

[mattgawarecki]

The UI for the theme modified event seems a bit off (I guess it should be similar to the plugin edited event [...])

I've created a new issue on our end (1164141197617539-as-1187358993941905) for Voyager to address this.