Wp-calypso: Footer credits changed via Customizer "Site Identity" options will not update

[mrfoxtalbot]

Steps to replicate

1. Go to My Site > Design > Customize https://wordpress.com/customize
2. Select "Site Identity" and change the Footer credit options:
   

I tested this with Modern Business and Twentynineteen

Result

The footer will not update

Expected

Footer credits should change accordingly

• User report: #2322311-hc
  Reproduced here: mrfoxtestingsite.wordpress.com

[geekinthegirl]

Another instance of this here: #15531608-hc

User changed their Footer Credit option to 'Hide', with no effect.

[chiape]

Hey there, we've just found a similar issue here and it only happens when changing the language to EN-gb.

Affected themes:

• Barnsbury
• Dalston
• Maywood
• Mayland

Also, instead of changing accordingly the link redirect to WordPress.org

[desnum]

Hi there,

I have another case in the Redhill theme, where "Hide" doesn't work to remove the footer credit only when the language is set to EN-gb.

zen-2523410

[zdenys]

Another case here 2572085-zen with Sophisticated Business Theme. But it seems that it affects many (if not all) themes and depends specifically on en-gb language being selected in ~https://wordpress.com/me/account~ https://wordpress.com/settings/general/

Possibly it affects any other non-English languages too as in https://github.com/Automattic/themes/issues/1222

[kwight]

I was hoping this might be a quick fix, but I've been unable to replicate. I tried in WP Admin and WP.com customizers, with en-gb and fr-ca languages, on both free and Premium plans. (I did notice that translations of the footer are not working in fr-ca, but I assume that's unrelated.)

Any other tips or indications for reproducing?

[zdenys]

I realized that in my previous comment I incorrectly indicated where en-gb should be set. It's in https://wordpress.com/settings/general/ (so for the site itself) and not in https://wordpress.com/me/account.

I can reproduce with Barnsbury, Dalston, Maywood, Mayland, Shawburn, Alves, Exford, Stratford, Coutoire, Morden, Stow, Hever, Leven, Brompton, Redhill.

Also reported here https://github.com/Automattic/themes/issues/1424 and here https://github.com/Automattic/themes/issues/1 (additional details here pNEWy-cyw-p2)

[kwight]

The cause is a regex problem, being unable to match on languages with country codes (eg. en-GB, fr-CA). A patch is ready for review in D36982-code.

[kwight]

Fixed in D36982-code.