Wp-calypso: FSE: Styling Fixes with Gutenberg v6.4

[gwwar]

When editing a Header or Footer, it looks like the min-height has changed for the wp_template.

Expected:

Actual:

To Reproduce:

• Visit horizon.wordpress.com/start/test-fse and create a new user
• Edit a page
• Click on edit header
• Compare page editing results with horizon.wordpress.com and wordpress.com

[kwight]

I'm not sure this is a bug to be dealt with at all (to be clear, the content of the header block itself is no different, it's the available editor space). The difference is introduced in https://github.com/WordPress/gutenberg/pull/16460/commits/11a6e935519bedf7effe0f1acf06bda0b3b8ad27#r312053881, as part of the 6.4 typewriter experience.

I played around with it, and I honestly can't see a huge difference in UX with it kept in vh or overridden to its original in px (unless there are mobile concerns, etc I'm unaware of).

@jasmussen @ellatrix any insight as to how vital this px to vh change is?

[gwwar]

Hmm @shaunandrews any strong feelings on this one? Thanks for looking into this more deeply @kwight

[jasmussen]

It is my sense, the vh unit is mostly decorative for the reading experience. But only Ella can speak on that topic with authority, and I defer to her.

However if the typewriter experience works as intended with a px unit and that makes life easier for you folks, I think it could be worth a core PR to change that. By "works as intended", I mean:

• When you type on an empty canvas, you type normally until you're at about 75% of the editing viewport height, at which point the Typewriter effect kicks in and keeps the caret at that spot.
• If you have a very long document already, and set focus near the top of the screen, the caret is also kept in place there at the top.

[shaunandrews]

Hmmm. This does break the encapsulated feeling we had previously where it felt like you were editing _just_ the header. With the expanded canvas, I worry people might get confused and think they’re editing a whole page and start adding more and more blocks (since there’s room for them) and mess up their header.

I’d prefer we get back to what we had previously.

[gwwar]

@kwight do things mostly work okay if we update styling when editing a wp_template? I believe we should add some parent CSS classes to help detect that.

[kwight]

I don't think we need to update core, it's our particular use-case that benefits from the change back to px (and it's just the visual that's affected, behaviour seems the same, as far as I can tell). I can do up an FSE PR to override back to px.

[kwight]

This was addressed by @Copons in #35821 .

[Copons]

Sorry for not noticing this issue earlier! 😢