Wp-calypso: Signup: Blog signup flow shows a flash of account screen at the end of the flow

[rachelmcr]

Steps to reproduce

1. Starting logged out at URL: https://wordpress.com/
2. Click "Get started" to start the signup flow.
3. Enter the details for your new account.
4. When prompted for your site type, choose "Blog."
5. Finish the signup flow, choosing a site topic, address, and plan.

What I expected

After choosing the free plan, I expect to finish signup and be taken to a logged-in screen.
After choosing a paid plan, I expect to finish signup and be taken to checkout.

What happened instead

After choosing a plan, I see an account details screen with this notice:

Your account has already been created. You can change your email, username, and password later.

The flow then automatically progresses to the next screen (the logged in checklist view for the free plan, or to checkout if I selected a paid plan).

Browser / OS version

Chrome 75.0.3770.100 / macOS 10.14.5

Screenshot / Video

Context / Source

manual-testing

cc @Automattic/start-dev

[ramonjd]

I can reproduce the bug even when logging in:

I think it was introduced here:

https://github.com/Automattic/wp-calypso/pull/34356/files#diff-515b9f6b5e27cdcebb984cf5d42edd35L191

@andrewserong

Did some ugly hacking around, ~but checking for the existence of lastKnownFlow seems to fix it, but it doesn't get to the core of what's going on~. (Doesn't fix it. See: https://github.com/Automattic/wp-calypso/issues/34403#issuecomment-507902190)

            if ( step.lastKnownFlow ) {
                return includes( flow.steps, step.stepName ) && step.lastKnownFlow === flowName
            }
            return includes( flow.steps, step.stepName );

Any ideas?

_edit_: At the domains steps, after having selected a blog site, I noticed that the last known flow flips to onboarding. It doesn't happen all the time though.

console.log( flowName, step.lastKnownFlow ) // -> onboarding-blog, onboarding

[ramonjd]

At the domains steps, after having selected a blog site, I noticed that the last known flow flips to onboarding. It doesn't happen all the time though.

Ah, it's only when you sign/log in for the first time. It's filtering the flow steps in getCompletedSteps() and checking the last known flow, but because we only fork at site type, the user step's last known flow is still onboarding

[ramonjd]

Maybe we can tell the filtered steps method that we're performing a resume? https://github.com/Automattic/wp-calypso/pull/34426/files

[andrewserong]

Thanks for reporting this @rachelmcr, much appreciated! — we've deployed a fix to revert the change that caused this issue. I'll work on a more permanent fix this afternoon, so will leave this issue open until it's resolved.