Wp-calypso: Comments: page views reported with non-normalized paths

Created on 21 Mar 2018  路  5Comments  路  Source: Automattic/wp-calypso

According to internal logs, some calypso_page_view paths coming from Comments are reported without replacing passed parameters with corresponding variables. In the following examples I'll be using [variable] to denote the places where these parameters appear (e.g. [comment_id] means that something like 123 was recorded in our logs, instead of :comment_id):

  • [x] /comment/[comment_id] (or some other id? - query: 1d6d8-pb)
  • [x] /comments/[status] (query: 1d6d6-pb)

For more details on how to obtain the logs, please check out the parent issue #16902 and p7jreA-1xN-p2.

You can also see a recent related fix for this here: https://github.com/Automattic/wp-calypso/pull/18414

Analytics Comments [Type] Bug

All 5 comments

Wondering if this is still relevant.

/comments should only reports normalized, manually written, paths created in the controller and passed down to Main that assign them to PageViewTracker:
https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/comments/controller.js#L65
https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/comments/controller.js#L94

/comment too only reports a normalized path:
https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/comment/main.jsx#L55

@Copons yes, the code seems fine, although if you run this query 1d6d6-pb for yesterday's stats you'll notice that we still have a small number of events recorded as /comments/all instead of /comments/:status.

Also, running this query 1d6d8-pb will show a small number of paths that are recorded as /comment/123 instead of /comment/:comment_id (most likely, but could be :site_id also?).

I'm still not sure what's causing this, but I've noticed the same weird issue in other sections too.

Note: I updated the issue summary to reflect the latest query results.

@Copons just a note that https://github.com/Automattic/wp-calypso/pull/23688 will probably resolve this one too.

@vindl Yes it should! 馃暫

Should be resolved with https://github.com/Automattic/wp-calypso/pull/23688, I'll keep monitoring the stats in the following days.

Was this page helpful?
0 / 5 - 0 ratings