Wp-calypso: Myanmar phone numbers not validating for 2FA

Created on 13 Mar 2018  Â·  6Comments  Â·  Source: Automattic/wp-calypso

Adding a phone number with a "9-" after the Myanmar (Burma) country code returns a validation error for 2FA.

Steps to reproduce

  1. Starting at URL: https://wordpress.com/
  2. Go to Security
  3. Click Two-Step authentication > Get Started
  4. Select “Myanmar (Burma)” in Country code
  5. Enter a phone number (minus country code) in the following format: 9-XXXXXXXXX
  6. Click “Verify via SMS” or “Verify via App”

What I expected

To be prompted to complete the verification process.

What happened instead

I saw the error, “That phone number does not appear to be valid”. It appears we only support phone numbers without 9- after the country code.

Browser / OS version

Chrome
Firefox
Safari

Screenshot / Video

myanmar-2fa

Context / Source

1011629-zen

user-report

manual-testing

p1520869751000532-slack-triage

Security [Status] Stale [Type] Bug

All 6 comments

Similar issue with Thailand phone numbers: https://github.com/Automattic/wp-calypso/issues/21862

I checked how we validate Myanmar phone numbers: https://github.com/Automattic/node-phone/blob/6be6549b03137f2cca01e202250bf2590750119e/lib/index.js#L1124

Numbers have to start with 9 but we only accept phone numbers with 8 numbers and the format you mentioned (9-XXXXXXXXX) is 10 numbers. It looks like we should probably be accepting numbers with at least 8-10 digits but I haven't confirmed that.

This ticket 1011629-zen has come back around after being on hold since March 13, 2018. Just checking to see if there is any progress.

Thanks

@gpmw There is some ongoing internal discussion (ref: p4TIVU-98g-p2) about how to proceed with this and related issues.

Just checking in again as the ticket has rolled through again. Any word?

1011629-zen

Thanks

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

Was this page helpful?
0 / 5 - 0 ratings