Wp-calypso: Simple Payments: Payment error for prices having decimal value

[arunsathiya]

Steps to reproduce: Follow the steps below to reproduce the issue.

1. Start creating a Simple Payments listing.
2. Use decimal value pricing.
3. Save the listing.
4. Try paying as an user.

What is expected: Payment is being processed.

What happens instead: PayPal popup appears (doesn't show the login view though) and closes in a split second. We see a "Payment did not create successfully" error later on.

(Edited, note that currencies like JYP do not support decimal units, so client validation in that case is expected).

[arunsathiya]

1945868-hc

[rachelmcr]

More information: We see a notice that decimal values cannot be used on certain currencies.

To clarify, are you also seeing this notice in the case described in this report? Or is this additional information. (That notice is expected for currencies that can't contain decimal values.)

cc @kristarella as you were troubleshooting another case involving certain values not working; not sure if this is the same as the issue you saw.

[arunsathiya]

To clarify, are you also seeing this notice in the case described in this report? Or is this additional information. (That notice is expected for currencies that can't contain decimal values.)

Hi @rachelmcr, reiterating what I mentioned earlier: We see this notice only for HUF and JYP, and not for other currencies.

Sorry, I should have mentioned this point above the image.

[millerf]

Hi,

I wanted to work on this issue, but I cannot find how to create a Simple Payments listing without having to upgrade my plan...

[nielslange]

1957716-hc

985422-zen

983281-zen

994143-zen

[rachelmcr]

Thanks @arunsathiya. The expectation from PayPal's documentation is that decimal values aren't supported for those currencies in particular, but they are for other currencies, so that notice is working as expected.

@millerf As far as I'm seeing this is a backend issue and not in Calypso, so it will likely need to be resolved internally. That said, if you'd still like to investigate it or other issues with paid plans I'd be happy to add you to a test site with a plan where you can take a look. Please let me know your WordPress.com username and I'll take care of that for you. :)

We also have a related issue for Simple Payments requests handling in https://github.com/Automattic/wp-calypso/issues/22388. (cc @iamtakashi in case you know who might tackle this and what priority it should have.)

[millerf]

@rachelmcr Yes, I would be happy to have a try. I think I saw a couple of other issues that I wouldn't mind investigate in the near future. My wordpress account is @millerf81. Thanks

[rachelmcr]

@millerf Great! I sent you an invitation to a test site; please feel free to investigate as needed there. Thanks again for getting involved with Calypso. :)

[retrofox]

Hi folks,

~My first question is how you are able to set a decimal price when the currency is JYP HUF.
The field validation seems to work well, avoiding adding or editing a new product when you try to define a decimal value.~

~Anyway, maybe we should improve the data validation when the product is saved in the server-side.~

https://github.com/Automattic/wp-calypso/issues/22939#issuecomment-371924752

[designsimply]

Tested and confirmed I cannot create a working payment button in USD for an amount such as $103.24.

Video: 1m34s

^{Seen at https://wordpress.com/post/design5279.wordpress.com/11926 (Business Plan) using Firefox 58.0.2 on macOS 10.13.3.}

^{Seen at https://design5279.wordpress.com/2018/03/09/payment-button-test/ using Firefox 58.0.2 on macOS 10.13.3.}

/hat tip 🤠 @kristarella and @alisterscott for troubleshooting at p1519790628000088-slack-triage.

[alisterscott]

This looks like it's actually ok if you use .25 decimal increments, so 1.25, 1.50, 1.75 etc. but not any other values after the decimal.

[gwwar]

@alisterscott are you still seeing the issue? This should have been resolved by D10823-code that was added by @retrofox

[alisterscott]

@gwwar kind of. It's working for me fine in Firefox and Safari now, but in Chrome I'm not seeing the Paypal button at all - separate issue?

Test post: https://eatkibbeling2.wordpress.com/2018/02/28/payment-button/

[gwwar]

I see it in Chrome for the example test post, do you have any extensions running?

[alisterscott]

Tampermonkey - sorry - all fine now

[alisterscott]

I can no longer reproduce this issue so I'm going to close this

@arunsathiya would you mind re-checking and comment/re-open as necessary?