Wp-calypso: Reader Search: Better "no results" state

[fraying]

Reader Search's "no results" state could use some love. Currently, at wide widths, we have POSTS and SITES columns even if one or both are empty:

Posts but no sites: https://wordpress.com/read/search?q=junotdiaz.com

Sites but no posts: https://wordpress.com/read/search?q=powazek.co

No results at all: https://wordpress.com/read/search?q=fishplops

So what should happen? I suggest:

1. If there are Posts but no Sites, omit the Sites column and let Posts have the full width.

2. If there are Sites but no Posts, omit the Posts column and let Sites have the full width.

3. If there are no results at all, omit both headers (Posts and Sites) and center the "no results" message, changing the text to say "No posts or sites found for..."

Does this make sense? Is it doable?

cc @jancavan @gibrown @samouri

[gibrown]

That sounds like a good solution. Yes please.

[jancavan]

If there are no results, I think the Relevance/Date sorter should also be omitted because there is nothing to sort in this case.

[fraying]

@jancavan Yes! Nice catch.

[fraying]

@jancavan Just one edit on the mock up there: it says "posts and sites" but I think we meant "posts _or_ sites"

[hrithik-jha]

Hi, I'm new here. I'd like to work on this. I've just cloned the repo and getting used to the code. Will get back with the change.

[romitgithub]

While going through this issue and reproducing it on my local machine I found another problem in the api call. While the results for search only contained one item, but the total count returned from server is random. And that caused the loader image to stay there as shown in the screenshot below

[romitgithub]

@gibrown Is anyone working on this? If not, I can take it up

[gibrown]

@romitgithub I doubt anyone working on it, but @bluefuton would know better at this point.

[bluefuton]

Thanks @romitgithub! Not being worked on at the moment but I'm happy to provide reviews if you pick it up.

[romitgithub]

Thanks @bluefuton! I'll start working on it. Also did you check the server issue that I mentioned in the earlier comment?

[bluefuton]

Thanks @romitgithub. I'm not able to reproduce the API issue with your example query "fishplops" 🙂If you can reproduce it, could you post the API response from your network console please?

[romitgithub]

@bluefuton I'm posting the api response screenshot here

[bluefuton]

Thanks for the screenshot @romitgithub. What's your interface language set to in https://wordpress.com/me/account?

[romitgithub]

@bluefuton It's set to English (EN)

[Saravanan90]

@bluefuton facing the same issue while checking sites column. It shows the loading UI forever. If it is resolved, I can get this issue fixed

[Saravanan90]

Can this issue be taken for a fix? It was raised an year ago, hence. Please confirm

cc @jancavan

[jancavan]

I'll be happy to review if there's a fix for it @Saravanan90

[ameersami]

@Saravanan90 @jancavan If either of you are not working on this I would like to take a crack at working on this

[Saravanan90]

@ameersami Issue has been analysed and fix is in progress. I'm facing the same issue as mentioned here, hence the delay

[nielslange]

@Saravanan90 Are you still working on a fix for this issue or shall I take over?

[Saravanan90]

@nielslange I have made analysis of this issue, but wasn't able to complete the fix.
If you have done with analysis and waiting for implementing the fix, kindly take over.
If analysis is yet to be made, I can complete the fix by this week

[nielslange]

@Saravanan90 I haven't started analysing this issue yet. Just wanted to know if you're still working on it. In this case, I'll leave this issue to you. 😀