Wp-calypso: Tortuga: Clicking "Create Site" after purchasing just a domain and then a plan leads to a loop and getting stuck

[fabianapsimoes]

Originally reported by @designsimply in 31-a8c-domain-search:

Steps to reproduce:

1. Purchase just a domain for a site on WordPress.com [Update: use an existing account].
2. Click the "Create Site" button on the My Sites > Settings page.
3. Select a theme.
4. Click the "Upgrade" button in the Personal column.
5. Submit payment—note that instead of a thank you page you still see the notice about there only being a temporary page (landing page) and the "Create Site" and "Manage Domain" options are all you can see on the main screen.
6. Refresh the blog front end to see whether the landing page is still there. (It's not.)
7. Click the "Create Site" button on the My Sites > Settings page again.
8. Select a theme again.
9. Click the "Upgrade" button in the Personal column again.

Result: if you try to use the "Create Site" option after purchasing just a domain and then adding a plan, you get stuck in a loop and eventually stuck at the "Awesome!" screen. (2m50s)

^{Seen at https://wordpress.com/checkout/thank-you/tellthislikeitis.blog using Safari 10.0.3 on Mac OS X 10.12.3.}

[fabianapsimoes]

@aidvu I'd guess this one might be related to https://github.com/Automattic/wp-calypso/issues/11668. What do you think?

[aidvu]

Not sure. The other one is more sites-list, while this is site-options from the looks of it. :) Should leave both for investigation.

[designsimply]

Re-tested and confirmed the problem is still happening: right after clicking the "Pay $15.88" button when adding a plan for a domain only purchase, I can see new options in the left panel but the main page still shows the "Create Site" and "Manage Domain" options and I can get stuck in a loop if I click "Create Site" again.

Video: 2m14s

^{Seen at https://wordpress.com/checkout/thank-you/thegamewereplaying.com/22764837 using Chrome 57.0.2987.98 on Mac OS X 10.12.3}

[designsimply]

Aha. I was missing a crucial piece. This problem only happens if you buy "just a domain" when already logged in as an existing user. Sorry I didn't catch that earlier! (3m3s)

[fabianapsimoes]

@designsimply Andrija and I are having a really hard time reproducing this consistently. I can reproduce it with one of my testing accounts, but Andrija can't using the same one. Then I tried with a brand new account and was unable to trigger the error.

Can you try and tell us a bit more about this? Does it happen all the time, with any accounts you use? Is it happening on all browsers? Did you use a credit card, credits or some other payment method?

[designsimply]

Re-tested and confirmed fixed. 😆 Video: 37s