Wp-calypso: Calypso not loading in Safari private window

[rachelmcr]

Steps to reproduce

1. In Safari on a computer, go to File > New Private Window, or in Safari on a mobile device, tap Private to open a new private window
2. Go to https://wordpress.com
   

   What I expected

I expected Calypso to load as usual.

What happened instead

I ended up on a blank screen with the WordPress logo, and the console displayed these errors:

QuotaExceededError: DOM Exception 22: An attempt was made to add something to storage that exceeded the quota.
TypeError: window.AppBoot is not a function. (In 'window.AppBoot()', 'window.AppBoot' is undefined)

Browser / OS version

Safari 9.1.1 (11601.6.17) / Mac OS X 10.11.5 (15F34)
Safari / iPhone 6 iOS 9.3.2 (13F69)

Screenshot / Video

Context / Source

user-report

113375-h

[rwaynick]

I'm still able to re-produce this issue using the same steps and received the same error as mentioned above.

A user initially contacted us about the same issue in a non-Private window on iOS (which I'm not able to re-produce at the moment), but was able to re-produce the issue in a Private window on Mac and iOS (iPad).

Safari Version 10.1 (12603.1.30.0.34), macOS Sierra 10.12.4

iPad Mini 4, iOS 10.3.1

[aduth]

@ehg @gziolo Could this have regressed with boot refactoring in #12395 ?

[gziolo]

I tested with Safari and private mode to validate if local storage shim works properly.

[gziolo]

It looks like error related to storage though.

[umurkontaci]

Safari throws whenever you call localStorage.setItem in private browsing, and it seems we are calling setItem before setting up the shim.

[fabianapsimoes]

This issue is also causing problems for social signup. @p3ob7o and @aidvu had reported getting stuck in the /start/social after authentication with Google. After a lot of troubleshooting, we noticed this only happens for Safari in private mode.

[fabianapsimoes]

Steps to reproduce the aforementioned problem:

• Open a private tab in Safari.
• Visit /start/social and choose to sign up using a Google account.
• A pop-up for authentication will open. Confirm all the steps there.
• Once the pop-up closes, notice that instead of being redirected to signup's processing screen, you'll be stuck on the user step.

In non-private Safari and in other browsers, the issue isn't reproducible.

[Tug]

@fabianapsimoes The signup bug is actually a different issue, I filled the bug here https://github.com/Automattic/wp-calypso/issues/13747

[klimeryk]

Created a PR to address this: https://github.com/Automattic/wp-calypso/pull/13748 (or at least get the discussion going ;)).

[gziolo]

@klimeryk we should rather get https://github.com/Automattic/wp-calypso/issues/13747 merged instead. @aduth opened PR which solves this issue and prevents future occurences caused by Babel's transpilation process :)

[aduth]

Might it be better to get the minimal fix in place if it's quicker to review, then follow-up with #7232 (think you intended to link to that?)?

[gziolo]

Yes, #7232 it is :)

[klimeryk]

I did not see any PRs referenced on this issue, so I assumed nothing is being done to address it and did not search through open PRs - great to know that's not the case 👍 Though, I agree with @aduth - #7232 has been open for a long time and if a minimal fix (I'll try to rework my PR based on his comment there) could be applied now, that'd be great.