Wp-calypso: Reader: Add in-content follow buttons support for Discover articles

[blowery]

Look for links in Discover articles with a data-blog-id or a data-feed-id and put a Follow button after them, inline.

[blowery]

Good test case will be https://wordpress.com/read/post/id/53424024/8946

The link at the end of each section should have a little Follow button after it.

[blowery]

Thanks @lancewillett :)

[lancewillett]

Is this still on the radar? Would be cool to see a visual mockup of what it'd look like.

Here's that mentioned test case now (Mac-n-Chrome, logged in as lancetest35 user).

[kjellr]

I agree, this would be a fantastic enhancement! I think there are a few different ways we could implement this.

As described in the note above, we could indeed place these buttons inline after the link. I'd imagine those looking something like one of these:

I don't think we have tiny buttons exactly like that one anywhere (I grabbed the button height of the "Manage" button in the Reader sidebar, but applied our normal button styles), but if we kept this inline, it'd need to be around that size so it doesn't mess with line heights when placed in the middle of a paragraph.

Alternatively, we could just add follow buttons in as separate block elements. Those data-blog-id / data-feed-id attributes don't exist in any posts to date, so we'll have to start from scratch and add these into posts manually anyway - how exactly we do it is still up for grabs. We could easily use something like <a href="https://theblog" data-blog-id="12345" class="follow-button">Follow</a> when we want a follow button, swap that out for buttons in the Reader, and work out a treatment for that class of links on discover.wordpress.com too.

@blowery + @jancavan, any thoughts on those options?

[jancavan]

The Follow button next to the site link looks good @kjellr. Perhaps we can just drop the period. We can also just propose a new button style for smaller buttons.

[stale[bot]]

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

[jancavan]

For Site Picks, we display the Follow button in both cards and fullpost, but for Editor's Pick, we only show them in cards. We should add them to Editor's Pick fullpost as well. /cc @jhnstn

[stale[bot]]

This issue has been marked as stale and will be closed in seven days. This happened because:

• It has been inactive in the past 9 months.
• It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

[blowery]

Closing this one down. For now?