Worldcubeassociation.org: Trainee delegates are listed on the Delegates page
According to @cubewhiz in #5118, Trainee Delegates are not (yet) WCA Staff and therefore should not be listed on the Delegate page.
It's probably just a matter of adding a .reject(&:trainee_delegate?) here.
I noticed this because the the "Trainee Delegate" badge has a link to the Delegates page, so ideally this badge should also be amended to not link there ^^
@danieljames-dj would you mind taking care of this please?
viroulep
All 4 comments
Sure, I would be happy to. I've sent a PR. I hope this will fix the issues.
danieljames-dj
on 27 Apr 2020
Ah, makes sense. I was curious why some Trainees were listed but others weren't.
maconard
on 27 Apr 2020
Because Seniors change delegate statuses, not the WST (but it's not related to this specific issue actually).
The changes were merged yesterday, which is also when the email to Senior/WCAT was sent, so just be patient until the appropriate person actually change your status.
viroulep
on 27 Apr 2020
Hadn't come on github for a bit, I didn't catch that this is all fresh from yesterday :) Great job to everyone who worked on getting it completed!
maconard
on 27 Apr 2020
Related issues
Jambrose777
路
3Comments
viroulep
路
6Comments
lgarron
路
9Comments
maconard
路
7Comments
AlbertoPdRF
路
4Comments
Most helpful comment
Because Seniors change delegate statuses, not the WST (but it's not related to this specific issue actually).
The changes were merged yesterday, which is also when the email to Senior/WCAT was sent, so just be patient until the appropriate person actually change your status.