Wordpress-seo: Can't select "make primary" for a term on custom taxonomy for custom post type

[KustomKode]

• [x] I've read and understood the contribution guidelines.
• [x] I've searched for any related issues and avoided creating a duplicate issue.

Once I upgraded to Yoast version 8.1, I could no longer select which term was the primary term on a custom post type, (I didn't try to reproduce the issue on a regular post.)

It no longer displayed which term had been previously selected as the primary, they all just said "make primary", and when clicked on nothing happened.

I had no other plugins installed at the time. After downgrading my Yoast version to 7.9.1, the problem went away.

I see the new version has added functionality for this same feature on the Gutenberg editor, but in doing so, has broken the classic editor.

How can we reproduce this behavior?

1. Create a custom post type
2. Create a custom taxonomy
3. Create at least two terms for the custom taxonomy
4. Create a new post and select both terms in the "Category" meta box on the edit page and try to make one of them the primary category, which is where it fails to function as expected.

Technical info

• WordPress version: 4.9.8
• Yoast SEO version: 8.1
  
• If relevant, which editor is affected (or editors):
• [x] Classic Editor
• [ ] Gutenberg
• [ ] Classic Editor plugin

* Which browser is affected (or browsers):
- [ ] IE11
- [ ] Edge
- [x] Chrome
- [ ] Firefox
- [x] Safari

• Relevant plugins in case of a bug:
  
• Tested with theme: Twenty Seventeen and a custom theme

[Beee4life]

I get this as well on a custom theme which runs on Timber.

[KustomKode]

Tested this issue again with version 8.1.1
The bug is still there.

[benvaassen]

I'm unable to reproduce this, can you send me a screenshot or GIF/video of what's not working and how it's behaving?

If it's related to Timber, it might also be because of issues https://github.com/Yoast/wordpress-seo/issues/10836 and https://github.com/Yoast/wordpress-seo/issues/10825

[Beee4life]

I don't get the errors referenced in the issues you mentioned.

This is a gif from me trying to click the primary taxonomy: http://g.recordit.co/1njNUyhOCL.gif.

[KustomKode]

This is not related to Timber for me... and the gif that @Beee4life sent is exactly my problem as well. I am unable to select a primary term, when you click on it, nothing happens.

And, terms that were previously set using an older version of Yoast, now just say "Make Primary"

[Beee4life]

I didn't think it was related to Timber, just wanted to mention it for info.

I just noticed, on another site (which has Events Manager installed which also has custom taxonomies) it does work... but only tested this with post type event, not any other types (yet).

[benvaassen]

I'm unable to reproduce it. Could you test this with all plugins deactivated and list the ones that are active plus version numbers? I'm thinking another plugin (or theme) might be causing this.

And are there any JavaScript errors?

[KustomKode]

No other plugins are installed, I will upgrade Yoast and check for javascript errors in a few hours.

[CarolineGeven]

Closing due to inactivity. If this issue is still relevant, please open a new issue with the requested information. Thanks for your understanding.

[Beee4life]

Only 16 days since last reply and you're already closing it ???

[KustomKode]

It is still broken. Can't upgrade Yoast past 7.9 if you want to be able to use primary categories.

---

From: Beee [e-mail]
Sent: Thursday, October 18, 2018 2:12 AM
To: Yoast/wordpress-seo
Cc: Jeremy Ratliff; Author
Subject: Re: [Yoast/wordpress-seo] Can't select "make primary" for a term on custom taxonomy for custom post type (#10877)

Only 16 days since last reply and you're already closing it ???

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Yoast/wordpress-seo/issues/10877#issuecomment-430900033, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHYT65Bgi1e2Gfv181yJYoNFQNUOi9sQks5umCnMgaJpZM4WWSHy.

[KustomKode]

I am guessing that it is still broken because no one has ever been assigned this ticket. I don't know what more you need? It don't work on a brand new install with ANY theme and no other plugins installed. It is really simple to reproduce. It has been this way ever since this functionality was updated to work with Gutenberg. I guess if your using the Classic Editor, you just don't matter.

---

From: Beee [e-mail]
Sent: Thursday, October 18, 2018 2:12 AM
To: Yoast/wordpress-seo
Cc: Jeremy Ratliff; Author
Subject: Re: [Yoast/wordpress-seo] Can't select "make primary" for a term on custom taxonomy for custom post type (#10877)

Only 16 days since last reply and you're already closing it ???

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Yoast/wordpress-seo/issues/10877#issuecomment-430900033, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHYT65Bgi1e2Gfv181yJYoNFQNUOi9sQks5umCnMgaJpZM4WWSHy.

[sara-p-]

I've been running into this same issue. I rolled back from version 12.3 to version 8.0 and the primary terms are working again for custom post types.

Has anyone figured out a fix for this?

[benvaassen]

I'm sorry to see this still seems to be an issue. We'd appreciate it a lot if you could open up a new bug report for us. Thanks a bunch!

[Beee4life]

On a side note... I find it a bit odd, this ticket was closed after little over 2 weeks already...

[KustomKode]

No... I have never figured it out either. And it seems Yoast has just closed the ticket without ever fixing the problem.

[KustomKode]

I have decided to not build anymore sites that need the "make primary" functionality for terms on a custom taxonomy. And the site I was having trouble with, I have just forced it to never update Yoast, to save myself hours of re-development.

[Beee4life]

I have decided to not build anymore sites that need the "make primary" functionality for terms on a custom taxonomy.

I've never built any functions that 'depend' on it...

[KustomKode]

I won't anymore. But the whole purpose of "make primary" is so you can build functions that query posts.

[Beee4life]

I won't anymore. But the whole purpose of "make primary" is so you can build functions that query posts.

I mostly used ACF (Pro) to achieve that...

[benvaassen]

To be fair, I think it was closed because we weren't able to reproduce it which makes it hard for us to find a fix. We were waiting on further details, like the mentioned JavaScript errors. We did fail to follow up after closing it, we should have replied but I can't change that anymore.

That's why I'm now asking to open up a new issue. I can only say I'm sorry for the late reply here.

[sara-p-]

New issue created here