Wordpress-ios: Site Creation: Tagline isn't set

[rachelmcr]

Expected behavior

When I enter a tagline in the site creation flow, I expect it to be set on the site.

Actual behavior

The tagline I entered isn't saved or displayed on my site.

Steps to reproduce the behavior

1. Go to My Sites and create a new WordPress.com site.
2. On the "Basic information" screen, enter a title and tagline.
3. After the site is created, check to see if the tagline is displayed.
4. Go to My Sites > Settings and check to see if the tagline is saved.

Result: The tagline is not saved or displayed.

Tested on [iPhone XS], iOS [12.1.4], WPiOS [11.9.0.20190225]

[designsimply]

Tested with WP Internal 12.0.0.20190311 on iPhone 6S iOS 12.1.4 and confirmed the tagline set during site creation is still not saved. (1m27s)

[ghost]

This comment from the corresponding Android defect suggests this might be a server-side issue. If so, it would account for the occurrence on both platforms.

[ghost]

@designsimply A discussion about this topic is underway via p1552602073005000-slack-bt-site-creation, and someone has been assigned. If confirmed as a server-side issue, it should not require a client-side fix. Otherwise, a change will need to be expedited.

cc: @malinajirka @oguzkocer @ctarda @kwonye

[ghost]

As for the behavior, I have double-checked the request sent in production (11.9), and can confirm that the tagline is being sent, as noted in the following payload.

{
    "validate": false,
    "options": {
        "site_vertical": "p23",
        "site_segment": 2,
        "site_information": {
            "site_tagline": "test"
        }
    },
    "public": 1,
    "blog_title": "11151a",
    "client_id": "11",
    "client_secret": REDACTED,
    "blog_name": "11151a",
    "lang_id": "1"
}

For reference, it was tested before the services were in place based on the contract (p9wMUP-bH-p2):

https://github.com/wordpress-mobile/WordPressKit-iOS/blob/develop/WordPressKitTests/SiteCreationRequestEncodingTests.swift

https://github.com/wordpress-mobile/WordPressKit-iOS/blob/develop/WordPressKitTests/SiteCreationResponseDecodingTests.swift

https://github.com/wordpress-mobile/WordPressKit-iOS/blob/develop/WordPressKitTests/WordPressComServiceRemoteTests%2BSiteCreation.swift

And after : #10712

[michaeldcain]

This was fixed in D25611-code.

[ghost]

Confirmed - thank you!