Wordpress-ios: NSInternalInconsistencyException in ReaderCommentsViewController updateTableViewForAttachments

[jkmassel]

From Fabric:

Fatal Exception: NSInternalInconsistencyException
0  CoreFoundation                 0x1b3705eb8 __exceptionPreprocess
1  libobjc.A.dylib                0x1b28fff18 objc_exception_throw
2  CoreFoundation                 0x1b3617ce0 +[_CFXNotificationTokenRegistration keyCallbacks]
3  Foundation                     0x1b41190fc -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:]
4  UIKitCore                      0x1e12bcb24 -[UITableView _endCellAnimationsWithContext:]
5  UIKitCore                      0x1e12d407c -[UITableView endUpdates]
6  WordPress                      0x104b3ff3c -[ReaderCommentsViewController updateTableViewForAttachments] (ReaderCommentsViewController.m:696)
7  WordPress                      0x104c9fb38 WPRichContentView.layoutAttachmentViews() (<compiler-generated>)
8  WordPress                      0x104ca0c64 closure #1 in WPRichContentView.imageForAttachment(_:) (<compiler-generated>)
9  WordPress                      0x104d4be70 partial apply for closure #1 in WPRichTextImage.loadImage(from:preferedSize:indexPath:onSuccess:onError:) (<compiler-generated>)
10 WordPress                      0x104fa97b8 partial apply for closure #1 in ImageLoader.callSuccessHandler() (<compiler-generated>)
11 WordPress                      0x104cb40a4 thunk for @escaping @callee_guaranteed () -> () (<compiler-generated>)
12 libdispatch.dylib              0x1b3107b9c _dispatch_call_block_and_release
13 libdispatch.dylib              0x1b3109134 _dispatch_client_callout
14 libdispatch.dylib              0x1b3114f50 _dispatch_main_queue_callback_4CF
15 CoreFoundation                 0x1b36940fc __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
16 CoreFoundation                 0x1b368ed78 __CFRunLoopRun
17 CoreFoundation                 0x1b368e2e8 CFRunLoopRunSpecific
18 GraphicsServices               0x1b5942be8 GSEventRunModal
19 UIKitCore                      0x1e10bc088 UIApplicationMain
20 WordPress                      0x104aaafbc main (main.m:11)
21 libdyld.dylib                  0x1b3141050 start

Looks like an issue caused by the number of rows in the table changing during the beginUpdates / endUpdates calls. The solution may be something like adding:

[self.tableViewHandler setListensForContentChanges:NO];

before and setting it back to YES after.

Source: 5c65cc93f8b88c2963d9b072-fabric

[aerych]

Making a note to check back on this one a week or so after 11.9 lands.

[designsimply]

Crashed a total of 6 times for 5 users in the last thirty days Feb 13 - Mar 14, 2019—iOS 12 only, no 11.9.
_{(5c65cc93f8b88c2963d9b072-fabric-ios)}

[aerych]

I'll give it one more week and if there are still no crashes I think we can close this one :)

[aerych]

New new crashes on 11.9 or later after the patch. Closing!