Wordpress-ios: Security notification doesn't show which site is it for

[koke]

I received a notification about a security threat on a site, but it didn't say what site:

When I tapped on the Activity Log link, it took me to stats:

Tested on WP Internal (9.4.0.20180221), iOS 11, iPhone 8

[MichaelArestad]

Ah! Good catch! Let's change it to:

Jetpack  found 1 issue on <a>Koke's Cool Site</a>. To review...

That would resolve the site issue, but leaves the fact that mobile doesn't have the Activity Log yet. @elibud do you have any suggestions for what to do here? Should we change the string for mobile users or change the link to point to the web app?

[elibud]

We should not use the same Notification.kind=Stats that we are using for the previously existing Stats since that will cause both Android and iOS to redirect to the Statistics screen.
Instead we should use a new kind, Activity since that will load the web version of the activity log for now, and we can redirect it to the native implementation in the future.
Let me know when the change is made and I can help testing it @MichaelArestad and thanks for jumping into this one.

[elibud]

Just got some help from @jleandroperez to properly debug this: the incorrect field is in body.ranges.type, currently set to stat instead of activity (my previous comment referred to the parsed info and not the raw data from the server).

[dmsnell]

Instead we should use a new kind, Activity since that will load the web version of the activity log for now, and we can redirect it to the native implementation in the future.

How do you feel @elibud about type='activity' for this new kind?
@roundhill do you see any issue with adding this new type for the Android app? (I don't know who is working on it these days)

[elibud]

That's perfect @dmsnell and on Android it would also be Hogwarts :)

[jleandroperez]

Anytime @elibud !! YO @dmsnell 👊

[dmsnell]

I think we really need an editorial review of this text. There are several things I don't like about it:

• There are grammatical bugs "to which to rewind" vs. "to rewind to"
• "you can head over to" sounds more awkward than the terser "head over to"
• There is a comma which isn't needed
• "Find a point before…" is unspecific about what a "point" is
• Many events in the Activity Log shows that threats were detected which are no longer present. This notification may lead people to believe they need to rewind past events they don't need to.
• Rewinding isn't the only resolution and it suggesting that with the text may lead people to rewind over legitimate events and lose work they performed since the threat was detected.

These can come in steps and don't need to have review for this specific change, but I think it would help out the notification.

[elibud]

@dmsnell @MichaelArestad maybe you want to move this item over to your repo to make sure it's worked on? If so please drop a link here and copy me so I get the notifications. Thanks

[dmsnell]

@elibud working on it now - no need to shuffle it around

[elibud]

Such efficiency! Thanks a million.

[jleandroperez]

@elibud let me introduce you @dmsnell. Dennis, meet Elisa.

Dennis is amazing. I still wonder how he manages to stay on top of EVERYTHING

[dmsnell]

Updates pending review in D10502 - I'll get some screenies soon!

[dmsnell]

Changes from the patch:

• no longer showing "found 1 issue" > replaced with "found an issue"
• two blocks for the description: "we found this" … "here's what you can do"
• site title now displayed and linked
• minor wording changes

One issue

Many issues

[roundhill]

Press a Bull

🤣

[dmsnell]

Merged in r170791-wpcom