Wordpress-android: Site creation preview shows cut-off site header

Created on 17 Nov 2020  路  9Comments  路  Source: wordpress-mobile/WordPress-Android

Expected behavior

The preview of a newly created site shouldn't have cut-off sections.

Actual behavior

After creating a site in the app, the site preview is shown but the top of the site is cut-off.

| Screenshot showing cut-off site preview |
| - |

Steps to reproduce the behavior

  1. Start the "Create WordPress.com site" wizard (either after the creation of a new WP.com account or from the site list when logged in)
  2. Create a Blank Site (although this issue might be present for other types of sites)
  3. On the "Your site has been created!" screen, notice that the top of the preview is cut-off
Tested on Samsung S10, Android 10, WPAndroid 16.0

Additional info

This issue is also present on WPiOS https://github.com/wordpress-mobile/WordPress-iOS/issues/15313

Site Creation [Type] Bug

Most helpful comment

We just shipped a PR that addresses this issue from the backend. @antonis and @chipsnyder As I understand it was addressed on the client side as well.

I am closing this issue for now but feel free to open it again in case. I misunderstood and there is more work to be done.

All 9 comments

Not directly related, but the subdomain is not readable in dark mode on the site creation preview screen and it would be cool for anyone working on this issue to see if that one can be fixed at the same time.

Noting that the "Create your website" banner showing in this view isn't expected during site creation and @enejb has submitted a PR on the WP.com side to fix it.

(internal reference: D53196-code, pbMoDN-1A9-p2#comment-3222)

This seems to be resolved now

Hi @antonis, I'm still seeing the "Create your website" banner in Play Store WPAndroid v16.1 when creating a new site, and the internal patch for WP.com side mentioned in https://github.com/wordpress-mobile/WordPress-Android/issues/13410#issuecomment-732507376 is still open. Which version did you see this resolved in?

| Screenshot showing the 'Create your website' banner |
| - |

If this is resolved, we should be able to close https://github.com/wordpress-mobile/WordPress-iOS/issues/15313 as well.

Hello @guarani 馃憢
This is solved on the client by adding the wordpress user-agent in the preview webview. This was done as a minor fix on the clients as part of:

This should be merged soon and be available in 16.3
Reopening the issue till this is done.

Hi @antonis 馃憢 I hadn't realized this was being fixed in the apps themselves, thanks for clarifying!

I'm curious if that means that the fix @enejb is doing (mentioned in https://github.com/wordpress-mobile/WordPress-Android/issues/13410#issuecomment-732507376) is addressing a different issue, or if it's no longer needed.

@guarani My understanding is that a fix was needed in both the server and the clients for this to work. I'll leave this open and recheck.

@guarani My understanding is that a fix was needed in both the server and the clients for this to work. I'll leave this open and recheck.

I see, thanks again @antonis!

We just shipped a PR that addresses this issue from the backend. @antonis and @chipsnyder As I understand it was addressed on the client side as well.

I am closing this issue for now but feel free to open it again in case. I misunderstood and there is more work to be done.

Was this page helpful?
0 / 5 - 0 ratings