Woocommerce-ios: Disabled state on buttons not working

Created on 29 Oct 2020  路  6Comments  路  Source: woocommerce/woocommerce-ios

Describe the bug
Our applyPrimaryButtonStyle method on UIButton seems to be applying the wrong style for the disabled state.

To Reproduce
Steps to reproduce the behavior:

  1. Apply applyPrimaryButtonStyle to any button
  2. Set it as disabled button.isEnabled = false
  3. See wrong style applied

Screenshots
Current | Expected
---- | ----
bad | good

Mobile Environment
Happening on iOS 13 and 14, both simulator and device

good first issue bug

Most helpful comment

I think the design for disabled primary button is the following (in "System - iOS Components" design board):

@Garance91540 feel free to correct!

\ | Light mode | Dark mode
-- | -- | --
Design | Screen Shot 2020-10-30 at 3 12 49 PM | Screen Shot 2020-10-30 at 3 12 58 PM
Text color | iOS System Quaternary Label Color | iOS System Tertiary Label Color
Border color | Same as text color | Same as text color

All 6 comments

I would like to do this if this task is still active ?

Sure @Denpex, let us know if you need any assistance. 馃憤

I think the design for disabled primary button is the following (in "System - iOS Components" design board):

@Garance91540 feel free to correct!

\ | Light mode | Dark mode
-- | -- | --
Design | Screen Shot 2020-10-30 at 3 12 49 PM | Screen Shot 2020-10-30 at 3 12 58 PM
Text color | iOS System Quaternary Label Color | iOS System Tertiary Label Color
Border color | Same as text color | Same as text color

@jaclync thanks for the heads up, I will make sure to follow these guidelines.

That's correct @jaclync , thank you!

Hi @Denpex do you still plan to work on this?

Was this page helpful?
0 / 5 - 0 ratings