Wled: Disable effects

[ToXIc-Dev]

Is your feature request related to a problem? Please describe.
I think it would be good to be able to individually disable each effect if you don't want some to be shown in the list

Describe the solution you'd like
In the settings you could toggle each effect on or off

Describe alternatives you've considered
The only other way I know of doing this is to remove them from the code

[Legsmaniac]

I'm confused.
Surely the way to "disable" an effect is to not select it in the first place?

[ToXIc-Dev]

I'm confused.
Surely the way to "disable" an effect is to not select it in the first place?

I mean to hide it from the list, the effects list is huge (not complaining, its great), not everyone wants to scroll through that many effects to get to the one they want, so disabling them means hide them from the list.

[Legsmaniac]

Ah, gotcha. So you'd like a kind of "favourites" list, or a way to favourite the effects you like best. Actually, that's not a bad idea.
Then again, wouldn't setting them in the Presets the ones you like best be another way round it? I understand there's a new version coming soon with far more presets to use so that might work?

[mike2nl]

-> So you'd like a kind of "favourites" list,

That's one of the missing things. Looking at @Aircoookie , haha.
But it can be solved with the 15 places to save an effect. number 16 is the all in one.

[Aircoookie]

Hi!
Yes, I too believe the upcoming possibility to save around 100 of your favorite effect configurations will be a good solution to the effect list being a bit long!

Also on my To Do list is to add extra controls besides Speed/Intensity to combine some effects, reducing the overall count.
For example, Candle and Multi Candle are the same except that with Multi Candle, every LED flickers independently. That could be consolidated to a single effect with a Multi checkbox. Similarily, the Halloween and Christmas effects are just Running 2 with Orange/Purple and Red/Green colors hardcoded.

[Joshfindit]

Quick question: What's the best way to pull the effects right out of the code?
I'm running warm white only, so only want a couple.

[Aircoookie]

@Joshfindit it's not that simple since it wasn't made for dynamically removing effects. You'd need to delete all references to the effect in FX.cpp and FX.h and modify the total effect count and the IDs of the effects you do want to keep accordingly.

What I'd recommend is setting up a preset for each effect you really like and ignoring the rest of them :)
In 0.11.0 releasing this sunday, you can store a lot more presets and you can even name them to keep track of which preset contains which effect!

Since you are not the only one who wants to hide some effects entirely (it would also have further benefits, e.g. being able to hide all effects from the list that could lead to photoelepsy), I will look into that. It would be enough to hide them after all, any disabled effect would still be compiled in and accessible via the API :)

[Joshfindit]

@Joshfindit it's not that simple since it wasn't made for dynamically removing effects. You'd need to delete all references to the effect in FX.cpp and FX.h and modify the total effect count and the IDs of the effects you do want to keep accordingly.

I was worried it might be something like that.
Thankfully I can live with just the first couple being the only ones, so I just erased all the names that follow those, and they are now unselectable from the UI and HomeAssistant.

What I'd recommend is setting up a preset for each effect you really like and ignoring the rest of them :)

That works quite well actually, even after my cheat. Thank you ☺️

In 0.11.0 releasing this sunday, you can store a lot more presets and you can even name them to keep track of which preset contains which effect!

!! 🎉!!

Since you are not the only one who wants to hide some effects entirely (it would also have further benefits, e.g. being able to hide all effects from the list that could lead to photoelepsy), I will look into that. It would be enough to hide them after all, any disabled effect would still be compiled in and accessible via the API :)

With the cheat I did above, I suspect a shortcut would to track the ID (aka array position) for each name, then selectively remove them from the names array when they are to be hidden