Winston: Large 'scratch' folder being distributed

[dougmoscrop]

Please tell us about your environment:

• _winston version?_
  
  
  
  • [x] winston@2
  
  
  • [x] winston@3
  
  
• _node -v outputs:_ v8.10.0
• _Operating System?_ macOS
• _Language?_ (all)

What is the problem?

npm install winston
du -sh node_modules/winston/*

This includes a scratch folder that is quite large (17MB) for 2.x. I think it just needs to be added to .npmignore, but it wasn't obvious to me how it was being generated or what the contents are supposed to be.

winston@3 has a small scratch folder, but maybe it's just a matter of a CI system accumulating a bunch of builds in a workspace over time?

I also noticed that some of the files intest are specifically not .npmignored, I'm curious if there's a reason why? The commits don't really explain why. Obviously those files are super small and not really significant, I'm just wondering.

[DABH]

Thanks for pointing this out. I'm not sure about those test files (@indexzero ?) but I added scratch to .npmignore on 2.x and 3.x, so next time @indexzero pushes a release (?), hopefully this will be resolved (definitely let us know if it's still being distributed). Thanks!

[vladgolubev]

winston 2.x like:

[indexzero]

I noticed this myself the other day – been afk for most of July. Yay vacations. Need to add scratch to .npmignore.

[indexzero]

Fixed in https://github.com/winstonjs/winston/commit/fcd5e685fe0c419a0db423b653f8c1368cc59641

[vladgolubev]

@indexzero any chance this can be backported to the 2.x.x as a patch? 🙏

And thanks for the fix @DABH !

[indexzero]

Yes it needs to be. Will make that happen now.

[indexzero]

Released in 2.4.4

[vladgolubev]

Thanks, @indexzero !

[indexzero]

For those curious scratch/** is where I started keeping samples / scratch pad space when I am attempting to reproduce / investigate Github issues for winston.

It was added to .gitignore, but I neglected to add it to .npmignore which was the source of the bug.