Problem description:
I cloned the current version of Winforms and tried to build it local, and I got error message (below with the command):
maestro@mmeniac:~/.vscode/extensions/WinForms/winforms$ ./build.sh
/home/maestro/.vscode/extensions/WinForms/winforms/eng/common/native/install-dotnet-api-docs_netcoreapp3.0.sh --baseuri https://netcorenativeassets.blob.core.windows.net/resource-packages/external --installpath /home/maestro/.netcoreeng/native//bin --version 0.0.0.1
Execution Failed: no install script
Before I updated file global.json with my actual dotnet versions in such way:
_{
"tools": {
"dotnet": "3.0.103",
"runtimes": {
"dotnet": [
"$(MicrosoftNETCoreAppPackageVersion)"
]
}
},
"sdk": {
"version": "3.0.103"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20171.1",
"Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20171.1",
"FIX-85B6-MERGE-9C38-CONFLICT": "1.0.0",
"Microsoft.NET.Sdk.IL": "5.0.0-alpha1.19513.3"
},
"native-tools": {
"dotnet-api-docs_netcoreapp3.0": "0.0.0.1"
}
}_
Probably I should make some other changes in global.json?
(but there is no explanations in corresponding documentation file about its parameters)
@SergeyMatsiupa on Windows dotnet-api-docs_netcoreapp3.0 emits a warning too:
Processing C:\Development\winforms\eng\..\global.json
dotnet-api-docs_netcoreapp3.0 was not found in .
Native tools bootstrap failed
In the interim, remove this line and try without it:
"native-tools": {
- "dotnet-api-docs_netcoreapp3.0": "0.0.0.1"
}
@chcosta this looks like an issue you fixed in https://github.com/dotnet/arcade/issues/4482. Though your fix applied to ps1 scripts, would the same fix need to be applied to sh scripts too?
There are few other issues here that I feel worth calling out:
sdk: version: 3.0.103, the version is too low. You should get an error:
\winforms\.dotnet\sdk\3.0.103\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(127,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 5.0.
Either target .NET Core 3.0 or lower, or use a version of the .NET SDK that supports .NET Core 5.0.
"native-tools": { - "dotnet-api-docs_netcoreapp3.0": "0.0.0.1" }oh yes, it helped well! thanks :)
2\. I do not believe you can have `sdk: version: 3.0.103`, the version is too low.yes, I had to install net core sdk 5.0 preview, but... isn't too strange to link stable version (as I said I cloned master branch of winforms) - to preview-version of net core sdk? 0o
anyway, I built it on my Ubuntu-PC)
also I got some other errors during the build process:
Build FAILED.
CSC : error CS1566: Error reading resource 'System.Windows.Forms.Design.professional1' -- 'Could not find file '/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/Resources/System/WinForms/Design/professional1.ico'.' [/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj]
0 Warning(s)
1 Error(s)
CSC : error CS1566: Error reading resource 'System.Windows.Forms.Design.professional2' -- 'Could not find file '/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/Resources/System/WinForms/Design/professional2.ico'.' [/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj]
0 Warning(s)
1 Error(s)
CSC : error CS1566: Error reading resource 'System.Windows.Forms.Design.Behavior.leftopen' -- 'Could not find file '/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/Resources/System/WinForms/Design/Behavior/leftopen.ico'.' [/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj]
0 Warning(s)
1 Error(s)
CSC : error CS1566: Error reading resource 'System.Windows.Forms.Design.Behavior.leftclose' -- 'Could not find file '/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/Resources/System/WinForms/Design/Behavior/leftclose.ico'.' [/home/maestro/.vscode/extensions/WinForms/winforms/src/System.Windows.Forms.Design/src/System.Windows.Forms.Design.csproj]
0 Warning(s)
1 Error(s)
_(I found a workaround by renaming the appropriate files to the appropriate folder)_
isn't too strange to link stable version (as I said I cloned master branch of winforms) - to preview-version of net core sdk?
Master branch isn't the stable version, its the working branch where all the latest changes go into.
Master branch isn't the stable version, its the working branch where all the latest changes go into.
The master is our "dev" branch, we don't release form it.
also I got some other errors during the build process:
If you don't mind, please send a PR with the renames. Thank you
If you don't mind, please send a PR with the renames. Thank you
I don't mind but it's not make a big sence :)
as I said I solved this throughout some brutal workaround (by renaming 3 *.ico-files, all are in my comment above), so better find them in System.Windows.Forms.Design.csproj and rename with correct case (problem was with inconsistency with case in names)
i think https://github.com/dotnet/arcade/pull/3496 may contribute to this
Most helpful comment
@SergeyMatsiupa on Windows
dotnet-api-docs_netcoreapp3.0emits a warning too:In the interim, remove this line and try without it:
@chcosta this looks like an issue you fixed in https://github.com/dotnet/arcade/issues/4482. Though your fix applied to ps1 scripts, would the same fix need to be applied to sh scripts too?