Windowscommunitytoolkit: Sample app crash on InAppNotification control

[jp-weber]

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

If I click in the InAppNotification control the 'Show notification with buttons (with DataTemplate)' button, the app crashes.

Minimal reproduction of the problem with instructions

1. Select InAppNotification control
2. click 'Show notification with buttons (with DataTemplate)' button
3. The sample app crashes

Environment

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [x] May 2019 Update (18362)
- [ ] Insider Build (build number: )

Device form factor:
- [x] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

[michael-hawker]

@Odonno, did we fix this, but have I just not updated the app yet or is this is a new issue?

[Odonno]

@michael-hawker I believe it's a new issue. The 5.1.1 sample app currently crash in the Windows Insiders version if I click this button.

[chan18]

look's like a simple issue, i am on it, never heard about about
WindowsCommunityToolkit before, going through this https://docs.microsoft.com/en-us/windows/communitytoolkit/,
excited to look into the code.

[michael-hawker]

Thanks @chan18, welcome! I hadn't gotten to take a look at this one yet, but if you have a PR to us by Monday, we can get a fix in the upcoming update to the app for our release next week. Otherwise, we can get an update in the next cycle.

Let us know if you have any questions, and be sure to see issue #3012 about building the toolkit locally at the moment.

[Kyaa-dost]

@chan18 is this still being worked on?

[jp-weber]

The in app notification control in the example app works again for me , so I would close this issue.