Windowscommunitytoolkit: RangeSelector tooltip bug

[EddieLotter]

I'm submitting a...

• Bug report (I searched for similar issues and did not find one)
  
  
  
  

Current behavior

The thumb's tooltip, activated with a mouse click, does not refresh when the thumb is updated using the keyboard.

Expected behavior

The tooltip should update no matter what input method is used to update the control's thumbs.

Minimal reproduction of the problem with instructions

The official Windows Community Toolkit Sample App can be used as the repro project.

To reproduce the issue, perform the following steps:

1. Click slightly to the right of the left thumb (or slightly to the left of the right thumb)
2. The tooltip for the thumb appears
3. Press the Tab key until the same thumb has focus and use the Left or Right Arrow key to move the thumb
4. Note how the tooltip does not update with the new position of the thumb.

Environment

Nuget Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [x] October 2018 Update (17763)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [x] October 2018 Update (17763)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [x] 2017 (version: )
- [ ] 2017 Preview (version: )

[EddieLotter]

Here is a quick visualization:

[nmetulev]

Thanks for reporting this issue. I believe there are two separate bugs here:

• The tool tip should disappear when clicked with the mouse and not remain visible
• The tool tip should be visible and work when using keyboard navigation

[deanchalk]

I wouldnt mind fixing this

[ST-Apps]

@deanchalk I started working on that before seeing your comment but I wasn't sure I'd have enough time for that, so I didn't comment here. Please let me know if you already started working on it.

@nmetulev as for Dean, I didn't see your comment when I started working on the issue. I've just committed a fix for @EddieLotter's bug report but I believe it doesn't behave as explained in your comment, as it just updates the tooltip when using keyboard after mouse events. Waiting for your feedback to understand what to do next.

[michael-hawker]

@ST-Apps did you still want to submit a PR for the fix? @deanchalk please feel free to review it as well.

[ST-Apps]

@michael-hawker done, waiting for a review.