Windowscommunitytoolkit: MasterDetail control has strange behaviors on HamburguerMenu App

[mvegaca]

Issue information

Hi.

I was working on Windows Template Studio Issue 1356 that reports a strange behavior on MasterDetail control. I've verified that this behavior only happens on Navigation pane projects (Hamburger menu control).

I was looking and the code and it looks like this behavior could be an Issue of MasterDetail control.
I've uploaded an isolated repro here.

Environment

Nuget Package(s): 
- Microsoft.Toolkit.Uwp.UI.Controls

Package Version(s): 
- 2.0.0

Windows 10 Build Number:
- Fall Creators Update (16299)

App min and target version:
- Creators Update (15063)

Device form factor:
- Desktop

Visual Studio 
- 2017 15.4

Thank you so much.

[nmetulev]

ping @skendrot

[skendrot]

Your sample repo works fine. I followed the steps in the WTS issue (using the repo you linked) and cannot reproduce.

[mvegaca]

Hi @skendrot

I've confirmed that it still happens.

Step 1
Open the app in wide state

Step 2
Navigate to Companies view.

Step 3
Reduce the window with enough to the Master/Detail shows only the detail but not enough to hide the navigation pane

In this case, Master/Detail control should keep in the list view, instead of the Detail View. With this situation when you click on go back the application returns to the Main Page instead of return from the detail to the list view in Master/Detail Control.

[mvegaca]

This situation does not happen all times but it can be reproducible. You should have to navigate between pages and grow and reduce the window trying to reproduce that.

[nmetulev]

Hmm, I spent some time trying to reproduce this with no luck, this is a tough one.

Master/Detail control should keep in the list view, instead of the Detail View.

This is not expected as there is an item selected in the control. If the item is selected, once you go in narrow view, the detail should be only visible, which is the case here.

[skendrot]

@mvegaca I'm still not able to reproduce this issue. What Windows environment are you able to reproduce this on? Maybe it's an issue with a particular SDK/Windows version?

[mvegaca]

I've added a repro steps mp4 vide Here.

My O.S. version: 16229.16

[skendrot]

Thanks for the video @mvegaca. When I click the back button it takes me to the Companies view (master view) without issue. I'm using your sample (Issue1356.Repro) and on build 16299.19

[Vijay-Nirmal]

I can repro this.

It didn't occur every time. But once it occurs, it occurs continuously.

[skendrot]

I cannot reproduce while debugging. I can reproduce when not debugging... This is going to be difficult to fix...

[Vijay-Nirmal]

@skendrot Experienced the same thing 😕

[mvegaca]

It looks it could be that when the window goes from wide to narrow, MasterDetail keeps on detail view but it doesn't add (sometimes) a go-back handling action to de system back button behavior.

[windowstoolkitbot]

This issue seems inactive. Do you need help to complete this issue?

[mvegaca]

Equivalent Issue on Windows Template Studio is always opened. Any news on MasterDetailControl?

[skendrot]

@mvegaca What do you mean "always opened"?

[mvegaca]

Sorry, I mean still opened.

[nmetulev]

@mvegaca, please test #1691 if it will resolve the issue.

[nmetulev]

Thinking about this more, and @azchohfi has pointed out, the fix I submitted to the MasterDetailsView to fix this issue will most likely will be a breaking change, and shouldn't be included until 3.0.

However, I believe there is something you can do in WTS to avoid this issue, and that is to remove this line.

@mvegaca, what do you think, is that acceptable?

[windowstoolkitbot]

This issue seems inactive. Do you need help to complete this issue?

[mvegaca]

Hi @nmetulev
It could be a workaround but if we comment that line the master detail control looks poor when it's opened.

In my opinion we should wait to V.3.0 on this Issue. Is there an a pre release way to test UWP Toolkit 3.0 before this will be available on Nuget?

[nmetulev]

Sorry about the delay @mvegaca . The current work in progress for this is in #1691. You could grab the packages from appveyor if you'd like to test, or build directly from the nmetulev/master branch. I will continue the work for this once 2.2 is released and once merged it will be available on myget

[nmetulev]

PR merged