Windowscommunitytoolkit: Selection change in Carousel

[TheSETJ]

Hey, Please add SelectionChanged event to Carousel.

[skendrot]

Hey @timheuer, another control we need Selector for

[nmetulev]

ping @Mimetis

[Mimetis]

Hi;
Thx for the feedback !
I don't know if any event on Dependency property are required anymore today, since you can do something like that :

carousel.RegisterPropertyChangedCallback(Carousel.SelectedItemProperty, (d, dp) =>
{
    Carousel cc = (Carousel)d;
    Debug.WriteLine(cc.SelectedItem);
});

Any thought @skendrot and @timheuer ?

[Odonno]

@Mimetis What if you want to invoke the event from XAML? I think adding the SelectionChanged event is not complex.

[Mimetis]

@Odonno : Right, not complex at all. But if I add SelectionChanged, maybe I should add all others Dependency properties related events ? (ie SelectedIndex, TransitionDuration, ItemDepth, EasingFunction, ItemMargin, InvertPositive, ItemRotationX, ItemRotationY, ItemRotationZ, Orientation

[ScottIsAFool]

@Mimetis they don't all need adding, we can add them on a per request basis after some discussion. Don't forget, even the built in controls don't have changed events for every DP.

[Mimetis]

Right !
Just wait for the @skendrot and/or @timheuer comments and, I will make a PR for this feature (that make sense, for sure)

[skendrot]

I think SelectionChanged makes sense for these controls. Would be a good add