Weechat: Relay plugin password is empty by default

[codedust]

When relay.network.password is set to "" (empty) it should not be possible to connect.

[flashcode]

Currently allowing an empty password (ie no password on connection) is a feature, not a bug. It could be used for example locally on a computer, or for tests. On the other hand, no connection on the relay is possible until you manually add a relay (type weechat or irc).

The user's guide mentions that the password is "highly recommended", but not mandatory: https://weechat.org/files/doc/devel/weechat_user.en.html#relay_password

I'm not against making it mandatory, if everybody is OK with that.

[Mikaela]

Not OK with making it mandatory. In addition to local testing, someone could have VPS or another host only on their use and WeeChat relay being only accessible from localhost or SSH tunnel in which case password would be just unnecressary complexion.

[Mikaela]

Maybe separate option for requiring password defaulting to yes?

[bendem]

I only use relay at home to access my laptop from my tablet so I don't use a password. I don't mind adding one if it becomes mandatory though.

[talisein]

If relay.network.bind_address is 127.0.0.1 then no password is fine. But otherwise there really should be a password IMHO.

[codedust]

I really like @Mikaela's idea to provide an option to allow empty passwords. Maybe something like relay.network.allow_empty_password which defaults to off. When setting up a relay, atm there is no authentication at all which can be a huge security/privacy issue.

[codedust]

:+1: Thanks! :tada: