Webpack.js.org: Deploy previews on each PR

Created on 19 Apr 2019  路  6Comments  路  Source: webpack/webpack.js.org

Can we setup deploy previews on each PR to quickly review the changes?

Netlify can do this pretty quickly, all we need to do it add the repo on it and it will provide a preview link on each PR.

@EugeneHlushko @montogeek

Most helpful comment

It works: https://github.com/webpack/webpack.js.org/pull/2953
Had to fine tune it, ty for suggesting, feel free to close

All 6 comments

@anshumanv IMO integrating Netlify is not required.
Because you can achieve something similar to this in VSCode. Read this

Just added an integration with netlify, lets see if it works for new PRs outside of my own. For myself looks like its building my own pr now: https://github.com/webpack/webpack.js.org/pull/2955

@anshumanv IMO integrating Netlify is not required.
Because you can achieve something similar to this in VSCode. Read this

Too complex in comparison to visiting a link. Also no "integration" as such. 馃槃

Just added an integration with netlify, lets see if it works for new PRs outside of my own. For myself looks like its building my own pr now: #2955

Build seems to be failing now, looking at the logs! @EugeneHlushko

@EugeneHlushko what's the build setting that you're using? I just deployed my fork and seems to work instantly - https://webpack-docs.netlify.com/
image

It works: https://github.com/webpack/webpack.js.org/pull/2953
Had to fine tune it, ty for suggesting, feel free to close

Awesome! <3

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jouni-kantola picture jouni-kantola  路  19Comments

webpack-bot picture webpack-bot  路  28Comments

herrvigg picture herrvigg  路  28Comments

dmitriid picture dmitriid  路  17Comments

TheDutchCoder picture TheDutchCoder  路  42Comments