Webogram: Refactor the project

Created on 25 Sep 2018  路  8Comments  路  Source: zhukov/webogram

I would like to help refactoring some pieces of code and send to you PR. I started with the controllers, separate each controller in one file, give more context and with this i know each controller is responsible for one thing.

You can see this changes in my forked repository and if you feel confortable i can make the PR.

https://github.com/iagocavalcante/webogram/commits/master

enhancement

Most helpful comment

@stek29, don't mix up Angular and AngularJS ;)

All 8 comments

I have the feeling that they're going to have a complete new web product after the Telegram X

I started this refactoring to understood how it works and improve my skills with angularJS (I'm using this in my current job), I want to build my own client using another tech stack when i finish this refactoring.

You have more information about Telegram X ?

nope, but they just announced that they're going to have Telegram X as the official app in iOS.
I would assume that they will move to Angular for the web, or something else

So, I don't will send the pull request. Thanks Bro!

@erezson How is that feeling justified? Also, webogram is already built using Angular.

I think, I can't send the PR now, because this is a huge change in the architecture. But I really joy if you help me with code review @erezson and @stek29

@iagocavalcante sorry, I'm not a developer but Product Manager :)

@stek29 I'm not saying that this is what gonna happen, but companies are moving from angularjs to angular so I would suggest to ask Telegram if there is a reason to have now refactoring before he starts

@stek29, don't mix up Angular and AngularJS ;)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

akaleeroy picture akaleeroy  路  8Comments

FacundoAcevedo picture FacundoAcevedo  路  6Comments

azzimuth picture azzimuth  路  5Comments

JohnChu101 picture JohnChu101  路  6Comments

Idran picture Idran  路  4Comments