Web: Redirect url with query parameters

Created on 2 Apr 2020  路  11Comments  路  Source: owncloud/web


This is important to get the logout finally working.
After a user logs out the oidc provider sends a redirect to https://localhost:9200?state=.
If the user tries to login again it won't work because the url is incorrect. The query parameter must be placed to another position.

Steps to reproduce

Logout of phoenix

Expected behaviour

The page gets redirected to login and the url looks like this
https://localhost:9200/#/login?state=

Actual behaviour

The page gets redirected to login and the url looks like this
https://localhost:9200/?state=#/login

Client configuration

Browser:
Any browser

p2 team Bug

Most helpful comment

@C0rby :+1: THX for clarification
@Talank lets just add UI tests where the user logs out using the UI and then tries to login again, if that works in all the environments we test automatically we should be fine

All 11 comments

I think the easiest way would be to set baseUrl + '#/login' as the redirect uri.

reopening and adding QA-team label to add tests

It looks like the pattern of redirect uri is not fixed. I tried to reproduce the issue using the current phoenix build with ocis backend. I am still being redirected to https://localhost:9200/?state=#/login

Can you provide more context? Are you doing the logout manually?
The fix was working fine with ocis so I'm a bit suprised.

When I do log out manually, then it takes me to https://localhost:9200/#/login?state= but when I try to go to https://localhost:9200?state= it takes me to https://localhost:9200/?state=#/login

Why would you like to go to https://localhost:9200?state=? I mean why do you need the state attribute? It's only needed for the openid flow.

Why would you like to go to https://localhost:9200?state=? I mean why do you need the state attribute? It's only needed for the openid flow.

because that is what the issue says :

Steps to reproduce
Try to open https://localhost:9200?state=

is there an misunderstanding?

Ah right, sorry....
I totally didn't get that.. Yeah the issue description is incorrect.
Let me change that

@C0rby :+1: THX for clarification
@Talank lets just add UI tests where the user logs out using the UI and then tries to login again, if that works in all the environments we test automatically we should be fine

tests done in #3572

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tomneedham picture tomneedham  路  3Comments

individual-it picture individual-it  路  5Comments

butonic picture butonic  路  8Comments

LukasHirt picture LukasHirt  路  4Comments

PVince81 picture PVince81  路  7Comments