Web: Grants description JSON, not plain text

[NukeManDan]

Describe the bug
Two issues:

• [ ] I cannot edit my grant description
• [ ] It is (as pictured) not rendering the text outside a JSON object.

https://gitcoin.co/grants/220/cryptorado/

To Reproduce
Any browser I try.

OS: Ubuntu MATE, Desktop
Browser: Firefox, Brave.

Screenshots

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.4 ETH (54.43 USD @ $136.07/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  
  
  
  • Want to chip in? Add your own contribution here.
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $73,537.09 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__Work has been started__.

These users each claimed they can complete the work by 3 weeks, 6 days from now.
Please review their action plans below:

1) iamonuwa has applied to start work _(Funders only: approve worker | reject worker)_.

Here to fix this as well. Investigate and get tit resolved.
2) pengiundev has applied to start work _(Funders only: approve worker | reject worker)_.

I'll start working on this right away. It's a fast and simple fix.
3) celebritydeveloper has been approved to start work.

I will get the json object and convert it to a string using Json.stringify() method so it can display the actual text.
4) dvshvwnn has applied to start work _(Funders only: approve worker | reject worker)_.

I hate to say it but you might want to restart the coding as long as you have everything backed up already. That way you can input the proper grant amount you want. As for the other issue, I'm not too knowledgeable on that so I cannot help just yet! (:

Learn more on the Gitcoin Issue Details page.

[celebritydeveloper]

Please, a quick question. Where do I get the codebase from?

[NukeManDan]

@celebritydeveloper - what do you mean....? the codebase for the website?

[celebritydeveloper]

Yes, I mean codebase for the website.

[celebritydeveloper]

@celebritydeveloper - what do you mean....? the codebase for the website?

Yes, I mean the codebase of the website.

[owocki]

this seems ready https://github.com/gitcoinco/web/issues/5754

[owocki]

@celebritydeveloper codebase is https://github.com/gitcoinco/web

[TomAFrench]

@NukeManDan
It seems to work fine for me on those platforms. Just to make sure... are you blocking javascript at all in firefox and brave?

[TomAFrench]

It seems to me that this issue is completely consistent with javascript being blocked in your browser (both the json display and lack of ability to edit) as shown in this code snippet

https://github.com/gitcoinco/web/blob/fe97b965ae4a5d25f34be59c328cea5299aadaf3/app/grants/templates/grants/detail/tabs.html#L135-L158

[thelostone-mc]

Thanks for the report @NukeManDan !
Got a fix ready !

@TomAFrench Ah yes sir! you've arrived at the root of the problem :D
I wish I'd seen this before starting to fix it :P would have saved me some time BUT THANKSS ❤️

[thelostone-mc]

This is fixed and deployed ^_^
Closing this out

[NukeManDan]

This is diplaying correcly now, but I am unable to edit in Firefox.

All javascript unblocked, and still unable to click any button. https://gitcoin.co/grants/220/cryptorado?tab=description

I get an error on clicking edit info:

ReferenceError: grant_description is not defineddetail.cfd55a0bd85d.js:41:9
    <anonymous> detail.cfd55a0bd85d.js:41
    jQuery 2
    d raven.js:445

Raven.js is running in my browser as well.

[NukeManDan]

@thelostone-mc - mid reopening this until a fix is made?

[owocki]

i can reproduce here too https://bits.owocki.com/jkunX8Pp

[owocki]

since @thelostone-mc went to bed (hes in india), i just put in a fix. mind testing now?

[NukeManDan]

Fixed.
Minor UX request - edit button unlocks ability to edit deception but the editor is enabled without hitting this. You can't edit until you hit the button, but it _feels_ like you should be able to.

New issue for the backlog? Or just me?

[thelostone-mc]

Ah thanks @owocki + @NukeManDan !
I should have caught that 🤦‍♂

@NukeManDan I'm closing this out now. Do reopen if anything related to this happens again

Minor UX request - edit button unlocks ability to edit deception but the editor is enabled without hitting this. You can't edit until you hit the button, but it feels like you should be able to.

Just pushed this in ! :)

[gitcoinbot]

@celebritydeveloper Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] reminder (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

Issue Status: 1. Open 2. Cancelled

---

__The funding of 0.4 ETH (57.34 USD @ $143.34/ETH) attached to this issue has been cancelled by the bounty submitter__

• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $80,263.80 more funded OSS Work available on the Gitcoin Issue Explorer