Web: bug - avatar is wrong skin color

Created on 3 Sep 2018  ·  15Comments  ·  Source: gitcoinco/web

screenshot
https://gitcoin.co/profile/owocki

Repro steps

  1. make an avatar. save it
  2. go to avatar builder
  3. wrong skin color is shown

expected behaviour:

  1. skin color is the same one as it is in my profile photo
bug frontend

Most helpful comment

@pmaojo, the issue is already fixed in https://github.com/gitcoinco/web/pull/2321.

All 15 comments

@owocki is this still a problem ? was it some cache issue ?

Can't seem to recreate in on local.
Also none of those avatar features ressemble you 🤦‍♂️

screen shot 2018-09-13 at 2 39 24 pm

screen shot 2018-09-13 at 2 39 32 pm

yes its still a problem in production for me. can you repro in prod?

I was able to reproduce this in production. See attached GIF
bug-avatarskin

@SaptakS is checking it out ^_^

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.__

Is this a reproduce-able issue? Seems to be working for me in production and on the current master branch. If it is, I'd be glad to take a look at it, but I can't seem to invoke the problem on my end.

Edit

By chance, did you mean the actual color selector is not correct? Like this:
Default_current

Since, the actual profile image updating seems to work in prod.
Link to fullres gif.

Was able to reproduce issue and found it's probable cause: it's because only background color is updated in localStorage where avatar builder takes colors from. Apart from skin tone issue also affects hair and clothing color. Will fix it shortly and submit PR.

The issue was that parsing colour from avatar element path was splitting with '.' and that was breaking on production, as domain also contains dots (as opposed to localhost). Fixed this by taking split part from other end.

@pmaojo, the issue is already fixed in https://github.com/gitcoinco/web/pull/2321.

thanks @evgeniuz I came from https://gitcoin.co/issue/gitcoinco/web/2150/1327, "created 18 hours ago"

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 6 months, 3 weeks from now.
Please review their action plans below:

1) evgeniuz has started work.

Already fixed the issue, starting work for gitcoin to track this.

Learn more on the Gitcoin Issue Details page.

thanks for the fix @evgeniuz -- @pmaojo sorry for the bounty miscommuny.. i didnt realize that @evgeniuz was already on it.

@evgeniuz its working ... thanks! can you submit work so i can payout

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by__:

  1. @evgeniuz

@owocki please take a look at the submitted work:

  • PR by @evgeniuz

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @evgeniuz.__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

christianbundy picture christianbundy  ·  3Comments

uluhonolulu picture uluhonolulu  ·  3Comments

kziemianek picture kziemianek  ·  3Comments

Skyge picture Skyge  ·  3Comments

wizzfile picture wizzfile  ·  3Comments