Web: Gitcoin explorer overwrites original bounty description with other user's arbitrary GitHub data

[dolebas]

User Story

As an issue funder, I expect input to the "Issue Description" form field to be displayed somewhere after funding an issue.

Description

Type: Bug

Current Behavior

Submitted the Fund Issue form funding the issue linked below but can't find the data I put in the "Issue Description" field displayed anywhere.

https://gitcoin.co/issue/uport-project/demo/42/314

Reproduction

Fund a new issue similar to the linked issue and enter data in the Issue Description field.

Environment

| Software | Version(s) |
| ---------------- | ---------- |
| Wallet | Metamask
| Browser | Brave
| Operating System | macOS

[mbeacom]

This description?

[dolebas]

No, that description was entered by the github issue creator, AlbertoElias, on Mar 12. I entered something like this below when funding the issue.

Definition of Done

Any end-user of uport-project/demo should be able to login using with an android device, without the requirement of copy/pasting any url between browsers/tabs.

[mbeacom]

Was the issue already funded? I am confused as to what you were doing in order to produce this outcome. What exactly were you funding? Do you see your bounty anywhere? Do you have a tx?
Apologies for the confusion.

[dolebas]

It wasn't previously funded. Simply followed the instructions. Can probably reproduce it by funding a new issue and take a screen shot of the exact form fields, if you are not able to reproduce it?

[dolebas]

Only thing I can think of is that I used markdown in the desc field.

[dolebas]

Also, my github has no write access to the repo.

[mbeacom]

Can you link me to the bounty you opened where you encountered this? The bounty description is populated with the Github issue description, but it is editable before submitting the bounty. I am not sure what you're question is. Which bounty of yours isn't displaying your provided description?

[dolebas]

Submitted few hours ago, the uPort demo one.

Is it assumed that the bounty creator = github issue creator?

[thelostone-mc]

@dolebas Don't hate me for this, but let me just revisit the steps you took in the same order

• Went to the fund bounty page
• Entered the github issue
• It got auto populate with what AlbertoElias had written

• You over-wrote it with

  Any end-user of uport-project/demo should be able to login using with an android device, without the requirement of copy/pasting any url between browsers/tabs.

• You clicked submit and the bounty on gitcoin still reflects what AlbertoElias had written

PS: Additionally I'm assuming since the description failed , you went ahead and manually pasted the comment here

Did I get that right ?

[mbeacom]

@dolebas Anyone can open a bounty for an issue. The bounty description should retain the description you enter. Could the data from GH have populated after you entered your description? The page makes a request against the GH api for the GH url associated description, title, etc.

Did the description already display:

After signing in and confirming transaction from the uPort app, my browser opens the callback URL that has the access token, but the site doesn't log in using that information

Did you remove this description and add yours or was there nothing there when you entered your description?

Sorry for the confusion! 😛

[thelostone-mc]

Is it assumed that the bounty creator = github issue creator?

Nope !

Also, my github has no write access to the repo.

Yeah this should still be fine ! If you were to fund an issue created by me -> you could do it via gitcoin
but the issue description section will be auto-filled from the github issue (and not from the comment posted by the bounty issuer )

[dolebas]

Not sure which order I filled in the fields, or if I deleted any placeholders, it is very much possible i was a bit #reckless

The desc field was quite small tho and a bit hard to overview.

[thelostone-mc]

@dolebas Ugh yeah !! You make a valid point ^_^
@PixelantDesign we need to give the description bigger. Everyone on github is used to a big box to list out the issue. This does seem cramped up

[mbeacom]

I agree we should probably expanding the size of the description text area.

[dolebas]

It seems like anything in the description field is automatically overwritten whenever the URL field is activated, regardless if the field is edited.

Maybe a prompt for a confirmation before edited fields automatically are overwritten would help? If the user has spent some time crafting a thought out description it could be a bummer if it is suddenly deleted because the URL field is mistakenly activated somehow?

No worries in my case tho, I just added the essentials as a comment to the issue, as you had already figured out @thelostone-mc :)

[owocki]

It seems like anything in the description field is automatically overwritten whenever the URL field is activated, regardless if the field is edited.

This is good feedback. We should probably make it clear that entering a github issue URL overwrites the desc text (or, per @dolebas 's suggestion, maybe ask for confirmation before we prefill if there is edited text there)

[dolebas]

If it helps, I noticed that there also seems to be some overwriting of the "Issue Title" field going on after the bounty is created as well.

Yesterday:

Today:

Maybe radio buttons in the bounty form for choosing custom or pulled title/desc would make it easier on the backend, and more clear on the frontend at the same time?

[thelostone-mc]

Hmm when I had checked on this yesterday I'd seen the same Not Working In Mobile 🤔
need to check this out

[dolebas]

Check gitcoinbot on twitter

[owocki]

yeah we sync the github title to the gitcoin title. cc @PixelantDesign maybe its worth making this a configurable option...

[dolebas]

interesting, original title is back!

[dolebas]

[PixelantDesign]

Thanks for reporting this @dolebas! Will take a look at some ways to handle this.

[PixelantDesign]

If I understand correctly seems like if a user starts editing content prior to the content fully populating, the additional information entered is lost.

Saptak and I discussed that a simple solution could be, we message that the information is loading and once that loads, we allow the user to edit the details (it’ll obviously need to get pushed back to Github along with the funded amount).

What do you all think of this approach?
@dolebas @owocki @mbeacom @thelostone-mc

[SaptakS]

it’ll obviously need to get pushed back to Github

@PixelantDesign most probably we won't be able to update the github description because of lack permission. Max we can do is maybe make a comment with the updated description. But maybe that doesn't exactly solve the problem.

[dolebas]

Thanks for picking up the discussion @PixelantDesign I believe the root cause for this issue is uncertain so any approach that simplifies synchronisation would help.

[dolebas]

If it helps, compare the description field on Bounties.network with the corresponding field on Gitcoin.

https://gitcoin.co/issue/uport-project/demo/42/314
https://beta.bounties.network/bounty/v1/314

Bounties.Network displays the (lost and found) title/desc submitted via Gitcoin, and Gitcoin displays the title/desc from GitHub.

This is not an isolated case, there are several bounties on Gitcoin with title/desc that doesn't match the original title/desc as listed on Bounties.Network.

[dolebas]

The steps to reproduce this issue would be:

1. Go to https://gitcoin.co/funding/new and fill out the form fields, in order
2. Edit the Title/Description field(s)
3. Take a screenshot and submit the form
4. Wait for ~24h
5. Compare the Gitcoin issue explorer with the screenshot (or the IPFS bounty contract data)

Feel free to reach out if anything is still unclear.

[kuhnchris]

@thelostone-mc / @dolebas can you still reproduce this bug?

[thelostone-mc]

Nah this was fixed