related to https://github.com/gitcoinco/web/pull/936#issuecomment-383610724 :
I would like to see pagination on the https://gitcoin.co/explorer page, such that when a query would return more than 100 bounties, that, another request would have to be sent with a ?offset=100 appended to it in order to return those next bounties
requested changes:
offset param for navigating those bountiesThis makes sense to me! Are you thinking infinite scroll for pagination?
Would just offset be sufficient? Maybe page_idx and page_sizesimilar as implemented in pitch pages list.
Also it would be good to have same pagination across the app. I have seen "Load more" buttons...
Eh. I feel like it'd be an odd experience to use Load more for the explorer bounty list.
I agree with you that we should ensure it's unified across the app, though.
Any thoughts on this @PixelantDesign @owocki @thelostone-mc @saptaks ?
i'm indifferent as to whether its an infinite scroll or a 'load more' button
@mbeacom @owocki I feel infinite scroll makes more sense to me. @kziemianek if we are going with an infinite scroll based approach and not allowing users to select max number of items in a page, I think offset should be enough. However, we can keep that implemented to have a scope for having such a feature to mention the page_size in future maybe.
Ah, offset as total displayed items - that makes sense!
__This issue now has a funding of 0.08 ETH (56.29 USD @ $703.65/ETH) attached to it.__
@kziemianek yes. 😃
@mbeacom I'd lean towards Infinite scroll cause it feels more natural but if we are sticking to load more, let's ensure it's the same throughout as suggested ^_^
Where do we have the load more buttons ?
Have we dropped out pagination btw ? (cause folks on github are used to the pagination, it's comfortable )
I've seen them in designs, for example #506
I'm going to start work on this, if someone wants to claim it , no worries as this is my first time with this project and still learning where everything is :)
Issue Status: 1. Open 2. Cancelled
__Work has been started__.
These users each claimed they can complete the work by 6Â months ago.
Please review their action plans below:
1) mikestonecodes has started work.
Learn more on the Gitcoin Issue Details page.
Hey I got this working nicely! I'm going to write some automated tests and try to break my code before submitting :)
@mikestonecodes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
*trying to get removed from issue , committed to PR yesterday :)
@mikestonecodes Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
@mikestonecodes due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
Hey @owocki looks like this issue lost some steam, do we still want to find another contributor for it?
im going to cancel this bounty
Issue Status: 1. Open 2. Cancelled
__The funding of 0.08 ETH (9.05 USD @ $113.15/ETH) attached to this issue has been cancelled by the bounty submitter__
Most helpful comment
Hey I got this working nicely! I'm going to write some automated tests and try to break my code before submitting :)