Web: No unsupported network alert on bounty funding

Created on 2 Apr 2018 · 9Comments · Source: gitcoinco/web

Type: Bug

Current Behavior

In case metamask is switched on unsupported network (e. g. ropsten) user can see a red alert in upper-left corner of Issue Explorer page or Issue Details page. But on Tools -> Fund Issue there are no any tests if the network supported. When user fills NewBounty form and pushes "Fund Issue" button the page is just reloading without any messages. So for user it looks like he can't fund for some unknown mystical reason.

Expected Behavior

Probably the same unsupported network alert need to be added on Fund Issue page. Or at least an error message after submitting the form.

bug

Source

Korridzy

Most helpful comment

@mkosowsk There is no issue in explorer in your case because of auto 'mainnet' filter. It looks like good enough solution for real usage.

Korridzy on 6 Apr 2018

👍3

All 9 comments

Interesting find, I attempted to fund this issue (fan of meta 😂) via Tools -> Fund Work while connected to the Rinkeby Test Net.

gitcoin co_funding_new

It looks like the transaction actually went through:

gitcoin co_funding_details__url https___github com_gitcoinco_web_issues_773

But issue cannot be found on Explorer:

gitcoin co_explorer_q no 20unsupported 20network

Beyond testing in Development, is there a reason for a User to be able to fund an issue if he or she is connected to Rinkeby Test Net? @owocki @mbeacom @thelostone-mc

mkosowsk on 3 Apr 2018

I don't think so! I've used it only in the dev environment !

thelostone-mc on 3 Apr 2018

@mkosowsk There is no issue in explorer in your case because of auto 'mainnet' filter. It looks like good enough solution for real usage.

Korridzy on 6 Apr 2018

👍3

We've been discussing limiting the live environment to only allow the creation of mainnet bounties, but as it sits currently, that's not the case.

@owocki Think we should pull the trigger on this and limit bounty creation to environment specific networks?

mbeacom on 9 Apr 2018

👍2

its worth a conversation... I can't say I have a strong opinion one way or another.. maybe worth a convo in the architecture weekly or the priv-contributes channel?

owocki on 9 Apr 2018

👍2

Per @mbeacom in the Slack

Would anyone like to weigh in on the conversation at: https://github.com/gitcoinco/web/issues/773 ? Specifically, the question: Think we should pull the trigger on this and limit bounty creation to environment specific networks? - For example, if you're browsing https://stage.gitcoin.co, you would be able to create Rinkeby bounties only. Whereas https://gitcoin.co would only allow you to create bounties for mainnet and local would allow either anything or testrpc and rinkeby.

I give a 👍 to this... even Ethereum pros like @owocki have burned ETH on testnets, and I was confused why I could seemingly fund an issue on Production via Rinkeby even tho it didn't go through. Think it's best to put the guardrails up in different environments to limit confusion for Users :)

mkosowsk on 9 Apr 2018

@mkosowsk -- Is the reason behind you couldn't find the issue on the explorer is due to the mainnet filter already applied on top of your search text? Probably the created issue is attached to rinkeby network filter maybe?

Either way, definitely funding of an issue on production should be restricted to mainnet. It doesn't make sense to support testnets on production environment.

@mbeacom -- I do agree with your proposed solution for having environment specific network. At the same time, we also need to check the domain url so that, if I run gitcoin on local with env=production but on localhost:8000, I'd still be using testnet and not the mainnet. I'm sure you might've already thought about this. Just wanted to highlight this as well.