Web-stories-wp: Element ratio lock and padding lock not persistent

[swissspidy]

Bug Description

When I unselect an element and select it again (or reload the editor), I notice that the lock is enabled again.

Expected Behaviour

When I disable padding lock, I expect this to be a persistent setting.
When I disable aspect ratio lock, I expect this to be a persistent setting.

Steps to Reproduce

1. Create new text element
2. Disable padding lock
3. Add some horizontal padding, but no vertical one
4. Element updates as expected
5. (Continue editing other elements)
6. Edit text element again
7. Change horizontal padding
8. Notice how vertical padding now suddenly changes again

Screenshots

---

_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

QA Instructions

[dvoytenko]

/cc @miina

[miina]

I wonder if this is something that should this be persistent between reloads as well e.g. as in #825? Or would this be per element persistent until the editor is reloaded?

[dvoytenko]

I think the padding specifically is more of a function of the current values. If horizontal === vertical, then the initial state of the lock should be on. Otherwise, it should be off.

[dvoytenko]

/cc @pbakaus it looks like my suggestion was a bad one. What do we want then here? Do we want lock state to be persisted in the data model? Or just always start on/off?

[pbakaus]

@dvoytenko just for posterity, the answer is we persist.

[ndev1991]

@pbakaus @dvoytenko We need to confirm the behavior when multiple elements selected.
When we have multiple element selected with different lock ratio value, we assume it as true and based on that calculate the size and padding.

@dvoytenko suggested that we need to have separate calculation on each element lock ratio value.
My question is if we need to separate the each calculation based on each element lock ratio for size and padding. And in that case what would be the status of lock ratio toggle?
Should it be disabled status?
/cc @samitron7

[dvoytenko]

@dvoytenko suggested that we need to have separate calculation on each element lock ratio value.

I also chimed in on the other thread and for posterity: I think both options are very possible. But I actually leaning toward your initial intuition now, and use the common lock ratio. What's most important though: whichever way we go, we should stay consistent. So, assuming a multiple selection with different lock rations and changing the width, I see two options:

1. Use per-element ratio and update height in one element, but not in the other. That means the width will show the common value (e.g. "100") and the height will be "multiple values".
2. Use the common ratio. E.g. if the common ratio is "locked", we update height in both elements. But then we should also set ratio to "locked" for both elements in the data model.

This way we preserve the consistency. The width, height, and lock are all as they were last updated.

And again, I'm leaning to the second option at this time.