Web-stories-wp: Broken positioning for one-tap links

Created on 3 Apr 2020  路  3Comments  路  Source: google/web-stories-wp

Bug Description

When adding a 1-tap link (aka element within amp-story-cta-layer), the absolute positioning is somehow broken and not based on the bottom 20% of the page.

This used to work (after it was once broken), but seems like it regressed again.

Only change that seems relevant is #916.

Expected Behaviour

1-tap links should be positioned correctly on the page.

Steps to Reproduce

Add text element with link in the bottom of the (second) page and check the frontend output.

The element is nowhere to be seen.

Screenshots

Editor:

Screenshot 2020-04-03 at 10 40 55

Frontend:

Screenshot 2020-04-03 at 10 41 12


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

QA Instructions

Editing P0 Bug

Most helpful comment

@wassgha are you actively working on this one?

(also congrats to @swissspidy for creating #1000 聽馃帀馃帀)

All 3 comments

FI: In my testing, the background (fill) showed up as expected, however, the text not.
See the editor:
Screenshot 2020-04-03 at 16 58 33

FE:
Screenshot 2020-04-03 at 16 58 53

@wassgha are you actively working on this one?

(also congrats to @swissspidy for creating #1000 聽馃帀馃帀)

Yes! Will have a PR for it today

Was this page helpful?
0 / 5 - 0 ratings