Web-stories-wp: RTL Support for Drag & Drop (Movable)

Created on 9 Mar 2020  路  9Comments  路  Source: google/web-stories-wp

Feature Description

Follow-up to #55 / #351

When using WordPress admin in RTL context (e.g. by changing your locale or by using the RTL Tester plugin), the X axis is basically flipped for Movable.

If dragging an element 10px to the left, it will be dropped 10px to the right. You can't miss it when testing.

Proposed solution:

Force canvas to be LTR, so that dragging an element to the left actually moves it to the left, and not the opposite.

Alternatives Considered

Additional Context


_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance Criteria

Implementation Brief

Accessibility Selection Workspace Internationalization (I18N) P1 Prometheus Enhancement

Most helpful comment

@o-fernandez @bmattb FYI added the 1.1.0 release to this.

I would really like to see this sooner rather than later. I don't think it should be too hard to implement, and I want to avoid lots of support questions and negative reviews because we haven't properly implemented RTL support yet.

All 9 comments

As mentioned on #351, an RTL UI does not mean that the document is RTL too.

We could force LTR for the canvas perhaps.

@swissspidy Would you mind specifying the issues with Movable? (If these are "specifiable").

@miina The X axis is basically flipped. If dragging an element 10px to the left, it will be dropped 10px to the right. You can't miss it when testing.

Alright 馃憤

Looks like it's not marked as a priority at this moment, otherwise, I'll take a look if/when it becomes a priority.

Correct, not a priority at this time.

Moving to backlog as I think it's fairly small to implement and is basically the last big missing issue for proper RTL support.

moving-problem-in-rtl

This bug is so big that we cannot use the plugin anymore. It would be great if you make changes to fix this issue.

@o-fernandez @bmattb FYI added the 1.1.0 release to this.

I would really like to see this sooner rather than later. I don't think it should be too hard to implement, and I want to avoid lots of support questions and negative reviews because we haven't properly implemented RTL support yet.

One thing to note: Make sure that rich text input fields (the _draftjs_ components) are still using the global direction rather than being LTR always - so you can still type Arabic and other languages correctly in text fields and they will be correctly aligned.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jauyong picture jauyong  路  4Comments

swissspidy picture swissspidy  路  3Comments

wassgha picture wassgha  路  3Comments

injainja picture injainja  路  4Comments

ernee picture ernee  路  4Comments