Waterfox: 68.0a2 tabs now have black background with black text

[laniakea64]

Describe the bug
In latest 68.0a2 tabs background is black with Default or Light theme. Because those themes use black text, this leaves the tab unreadable and visually unusable.

To Reproduce
Tools > Add-ons Manager > Themes, enable either Default or Light

Expected behavior
Tabs should be gray/light-gray with black text.

Screenshots

Desktop (please complete the following information):

• OS: Xubuntu 18.04
• Waterfox 68.0a2 self built from https://github.com/MrAlex94/Waterfox/commit/b5059dc5ab2699d335dfa9c8c01a5a3c3a7942bd

Additional context
Sometimes the tabs look as expected briefly after a restart. But as the browser is used, e.g. if the Add-ons Manager is opened, it will revert back to the unusable black background.

The black background also happens with Dark theme and with personas, but in those cases the text is white and light grey respectively, so one workaround could be to use either Dark theme or a persona.

[grahamperrin]

68.0a2 on Windows (to the right), default theme:

– and light:

[grahamperrin]

Reproducible with (unannounced) build 20190906171246 of 68.0b1:

Below, the bug is not immediately apparent – it occurs (for example):

• after taking the about:preferences route to about:support

https://s.put.re/pbN6Ux85.mp4

Another example, thanks to @troysjanda:

• after taking the hamburger menu route to about:addons

… and so on.

[grahamperrin]

Cross references:

• https://www.reddit.com/comments/d15yea/-/ezr7139/?context=1
• UserChrome.css stops working if user open about:addons : waterfox

[MrAlex94]

Hmm, will see look into why the CSS isn't unregistering properly.

[laniakea64]

Hmm, will see look into why the CSS isn't unregistering properly.

@MrAlex94 Because it's being reapplied by this code -
https://github.com/MrAlex94/Waterfox/blob/ab1960eee6162fd2b824118e3208414013718f7d/toolkit/mozapps/extensions/internal/AddonSettings.jsm#L67-L72

[MrAlex94]

That’s correct, looks like I missed out the unregister code I used when
testing.

On Thu, 19 Sep 2019 at 00:00, laniakea64 [e-mail] wrote:

Hmm, will see look into why the CSS isn't unregistering properly.

@MrAlex94 https://github.com/MrAlex94 Because it's being reapplied by
this code -

https://github.com/MrAlex94/Waterfox/blob/ab1960eee6162fd2b824118e3208414013718f7d/toolkit/mozapps/extensions/internal/AddonSettings.jsm#L67-L72

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/MrAlex94/Waterfox/issues/1090?email_source=notifications&email_token=ABECQWG5MTGV7EJMK7DJND3QKKXIPA5CNFSM4IJFV3UKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BWIKI#issuecomment-532898857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABECQWBYVBED4DOMOSKGOS3QKKXIPANCNFSM4IJFV3UA
.

[laniakea64]

Fixed by https://github.com/MrAlex94/Waterfox/commit/0e1ff89a741a6853547465dd0d5d6ae9ffad6684 . Thanks! :+1: