Waterfox: AMO: port changes from Firefox 59 for compatibility with themes that appear to be for Firefox 53 and later

Created on 17 May 2019  Â·  16Comments  Â·  Source: MrAlex94/Waterfox

Note

When this issue was opened, I assumed that incompatibilities related to COSE.

Re: https://github.com/MrAlex94/Waterfox/issues/972#issuecomment-495521922 below it seems that COSE is unrelated so to minimise confusion, I'm removing much of my commentary (it'll remain visible through use of the _Edited_ menus).

Distinguishing this issue from Mozilla armagadd-on 2.0

At https://github.com/mozilla/addons/issues/851#issuecomment-489277802 _Wood time_ (amongst the test cases below) bugged both Waterfox and Firefox on Saturday 2019-05-04 – coinciding with the onset of armagadd-on 2.0.

Since fixes for armagadd-on became available:

  • release versions of Firefox are no longer bugged
  • as far as I can tell, Waterfox 56.2.9 remains without support for recent versions of themes at AMO.
picture grahamperrin

All 16 comments

(COSE-related commentary removed.)

grahamperrin picture grahamperrin on 18 May 2019

Test cases

Themes:

– and so on.

grahamperrin picture grahamperrin on 18 May 2019

I’ll need to keep an eye on how this will affect Waterfox. Thanks for the
links. I hope that disabling signature requirements will still be available
to stop any issues in the future.

On Sat, 18 May 2019 at 09:57, Graham Perrin notifications@github.com
wrote:

Test cases

Themes:

– and so on.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MrAlex94/Waterfox/issues/972?email_source=notifications&email_token=ABECQWACWRU5YO3UXC3WF33PV7AF5A5CNFSM4HNRILX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWKVBY#issuecomment-493660807,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABECQWAN33RUUD2NCP75KGLPV7AF5ANCNFSM4HNRILXQ
.

MrAlex94 picture MrAlex94 on 21 May 2019
👍1

Hello again :-)
Thanks for this great update eg captchas change is awesome!
Just to continue from the other thread (#966). I installed the AUR's 56.2.10 temporarily, cleared cache/cookies, and extensions install, which is great, but unfortunately not themes eg https://addons.mozilla.org/en-GB/firefox/addon/under-the-deep-blue-sea/?src=featured. I tried right-clicking to save then load the theme manually, but error said corrupt.
Unfortunately it's not possible to search themes on the Wayback, so I'm not sure what to do.
(Manjaro KDE Stable)

linuxgirl22 picture linuxgirl22 on 21 May 2019

Themes (personas/appearance) at AMO

At this time, in most cases of incompatibility there are (touch wood) multiple versions; and where:

  • the most recent version of a theme can not be added to 56.2.10
  • a less (or least) recent version can be added.

So for example @linuxgirl22 at https://addons.mozilla.org/addon/under-the-deep-blue-sea/versions/ you'll be able to add version 1.0.

grahamperrin picture grahamperrin on 21 May 2019

Themes at AMO

In my limited understanding, where a page states:

Works with Firefox 53.0 and later, …

– for a theme that can not be added to Waterfox 56.2.10, strictly speaking the statement could be more like:

Works with Firefox 59.0 and later, …

Given that 59 falls below the currently supported version 60 of Firefox ESR, I should not expect a fix in Mozilla's /addons-frontend/ area of GitHub.

No response (from any user of an unsupported version of Firefox) to https://discourse.mozilla.org/t/-/39845/46?u=grahamperrin and really, I don't expect one.

Side note: https://discourse.mozilla.org/t/-/36770/2?u=grahamperrin re future _types_ of add-on.

grahamperrin picture grahamperrin on 21 May 2019

"So for example @linuxgirl22 at https://addons.mozilla.org/addon/under-the-deep-blue-sea/versions/ you'll be able to add version 1.0."
Thanks grahamperrin :-) ... that's worked great, and I've found how to access the older versions.

linuxgirl22 picture linuxgirl22 on 21 May 2019
👍1

(COSE-related commentary removed.)

I wonder, what else is significant about:

  • the themes that were released on 2015-09-13
  • the Wood time theme, version 1.0 released 2019-04-05
grahamperrin picture grahamperrin on 24 May 2019

I ported the changes from bug 1415878 and bug 1442437 to C:\Program Files\Waterfox\omni.ja, and the test case themes successfully installed themselves on Waterfox 56.2.10 on my Win7.

Here are some of the most recent changes related to theming; see also bug 1347171.

Maybe someone can take a closer look into this?

Lorienna picture Lorienna on 24 May 2019
❤1

Thanks @Lorienna! So I was way off with the COSE assumption. I should change the title of this issue, what would you suggest?

grahamperrin picture grahamperrin on 24 May 2019

Changing the user agent (as well as general.useragent.override.addons.mozilla.org) seems to have no effect.

I randomly tried to install a handful of different themes, not a single one added after the early May addon debacle worked; but versions added prior, all installed successfully.

I am curious if anyone else has come to the same conclusion - that the checking is being done at their end and not browser-side? They're checking some sort of identification string and refusing the download based on the version (or browser UA.. Waterfox) returned. Perhaps something uploaded along with the new versions that wasn't present in earlier versions.

Example:

Works with firefox 53.0 and later, android 65.0 and later

for both available versions: https://addons.mozilla.org/en-US/firefox/addon/dark-blue-fog/versions/ - yet only the one uploaded in January works; the version uploaded May 13th will not download.

Has anyone encountered any themes added after the debacle that will install?

Did all of these theme authors really upload new versions on the same day...? Or did Mozilla roll out of a change on May 13th that forced new versions into the database?

Found one added in April that does not download: https://addons.mozilla.org/en-US/firefox/addon/outer-clouds-space/versions/ - version from January, does.

angela-d picture angela-d on 26 May 2019
👍1

Changing the user agent … seems to have no effect.

True. From Waterfox 56.2.10 compatibility with addons.mozilla.org (AMO):

user agent (UA) strings are not a workaround

Sorry! I should have begun this issue with a cross-reference to the post in Reddit, but at the time I wasn't certain about the COSE stuff.

To help people in your situation:

grahamperrin picture grahamperrin on 26 May 2019

An example of the effect, on themes, at about:addons

image

There was an error downloading …

grahamperrin picture grahamperrin on 10 Jun 2019

https://github.com/MrAlex94/Waterfox/commit/c2d131b2df0cff955a11bd6cbf0b1546d6fa7aac
https://github.com/MrAlex94/Waterfox/commit/ac11ae3d342952d2a8ba0d4c2a7edd4b9a2b0e76

Thanks to @laniakea64 for the bugs. I've tested and seems to work well. Please re-open if you spot any issues related to the changes.

MrAlex94 picture MrAlex94 on 19 Jun 2019
❤1

Thanks to @laniakea64 for the bugs.

Not me :P
Credit for this goes to @Lorienna https://github.com/MrAlex94/Waterfox/issues/972#issuecomment-495521922

laniakea64 picture laniakea64 on 19 Jun 2019
👍1

Oops, wrong tag heh.

On Wed, 19 Jun 2019 at 14:10, laniakea64 notifications@github.com wrote:

Thanks to @laniakea64 https://github.com/laniakea64 for the bugs.

Not me :P
Credit for this goes to @Lorienna https://github.com/Lorienna #972
(comment)
https://github.com/MrAlex94/Waterfox/issues/972#issuecomment-495521922

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/MrAlex94/Waterfox/issues/972?email_source=notifications&email_token=ABECQWDE2RZMVOWOWTDQXWDP3IV55A5CNFSM4HNRILX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBZ7QA#issuecomment-503553984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABECQWEOC7FORSZDVYLHOJLP3IV55ANCNFSM4HNRILXQ
.

MrAlex94 picture MrAlex94 on 19 Jun 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Kallinteris-Andreas picture Kallinteris-Andreas  Â·  3Comments
laniakea64 picture laniakea64  Â·  3Comments
GitCurious picture GitCurious  Â·  3Comments
sutex picture sutex  Â·  3Comments
hook321 picture hook321  Â·  4Comments