Walletwasabi: Clicking "Receive" in wallet explorer replace the opened "Receive" tab and change the order of wallet.

[Transisto]

To reproduce:

Click load to load first wallet

Double click 2nd wallet

Click receive on 2nd wallet

Receive TAB of first wallet, [coldcard] is replaced by the the one just clicked [Ledger]

Click first wallet "Receive"

(edit in progress...........

[Transisto]

Actually

Click not first wallet, Load

(or double clicking using "Wallet explorer")

It become open as first one

Click another one
Order of open wallet changes a

And first Receive TAB is being REPLACED instead of opening a new one. Notice how it also doesn't have an highlight of which wallet this receive tab is about. (it's wallet "nothing")

These inconsistencies might lead someone to request funds to be sent to the wrong wallet.

[Transisto]

Somewhat related to https://github.com/zkSNACKs/WalletWasabi/issues/3509 but actually worst.

[yahiheb]

Here is the rational on how loading multiple wallets work:
The first time you load a wallet, 4 tabs will be open.
When you load other wallets, no tab will be open, to not fill the GUI with open tabs, you have to manually open the tabs that you need.

Notice how it also doesn't have an highlight of which wallet this receive tab is about. (it's wallet "nothing")

That is because you just clicked on Coldcard0 wallet and loaded it.
If you go and click on the receive tab it will synchronize with nothing wallet.
But this can be improved by making the Receive tab less blue or grayed out.

There is an address in one of the pictures you shared, you might want to delete that or edit the comment.

[garceri]

The tab interface very confusing to navigate if you Click on Send/Receive on multiple wallets, with no clear hint about what wallet each tab belongs to, which can lead to (costly) mistakes:

[Transisto]

That is because you just clicked on Coldcard0 wallet and loaded it.

No, I just clicked Receive tab up top.

Expected behavior is that when I click Receive on 2nd Wallet it open a new Receive, not replace the existing one.

[MaxHillebrand]

The current situtation with tabs is only a stepping stone, we should not try to fix minor issues in the current version, but rather figure out how to do it right in an overaching refactor of the UX.

Thanks for reporting this @transisto & @garceri, good to get confirmation that this current UX is shitty, and what would you suggest for a whole fresh UX?

[Transisto]

and what would you suggest for a whole fresh UX?

Not whole refresh but this seems like a quick fix

or

[Transisto]

Btw good to remove the load wallet page, but also think of either making
Wallet Explorer single click or have a `>' so people know to click there to
expand your the wallet.

On Tue., Apr. 7, 2020, 17:53 Max Hillebrand, [e-mail]
wrote:

The current situtation with tabs is only a stepping stone, we should not
try to fix minor issues in the current version, but rather figure out how
to do it right in an overaching refactor of the UX.

Thanks for reporting this @Transisto https://github.com/Transisto &
@garceri https://github.com/garceri, good to get confirmation that this
current UX is shitty, and what would you suggest for a whole fresh UX?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zkSNACKs/WalletWasabi/issues/3510#issuecomment-610639238,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC643G24T7N4HHGTYFGW6TRLOOF7ANCNFSM4MDLIIDQ
.

[yahiheb]

That is because you just clicked on Coldcard0 wallet and loaded it.

No, I just clicked Receive tab up top.

Followed exactly your steps and when I click Receive tab up top, the Receive item of 'nothing' wallet in the Wallet explorer is selected, which is correct.

Expected behavior is that when I click Receive on 2nd Wallet it open a new Receive, not replace the existing one.

This is exactly what is happening, it never replaces an existing tab.

[yahiheb]

@Transisto @garceri
Take a look at this https://github.com/zkSNACKs/WasabiDesign/issues/8 about multi-wallet UX.

[Transisto]

@yahiheb You're right but where the confusion come from that closed wallets are ordered by alphabetical, then open wallet are also sorted by alphabetical but on top of closed wallet.

That extra reordering is mixed with, open wallet starting from top.

IMO either wallets should stay where they are and just open up or they should get from the top down in the order they were opened.

[MaxHillebrand]

IMO either wallets should stay where they are and just open up or they should get from the top down in the order they were opened.

What do you mean?
A wallet cannot be "closed" / unloaded, only the drop down menu of the functions can be collapsed...

[MaxHillebrand]

IMO either wallets should stay where they are and just open up or they should get from the top down in the order they were opened.

What do you mean?
A wallet cannot be "closed" / unloaded, only the drop down menu of the functions can be collapsed...

[Transisto]

The invisible switchich to me happen when given 3 wallet A B C,
C is loaded/expanded, gets moved to the top, then if B gets opened it
instantly move from being below the current wallet to being above. So
either you sort the wallet by alphabetical order or you sort them by opened
or not but not both.

Consider most people don't know or care what the sorting is and to them
when a wallet is expanded it suddenly get moved up, OK. then if another
wallet is expanded it is also moved up, but no just up, up above the first
one _if alphabetical is higher_ , which is two resorting at once.

Please don't move items into the list, normal people don't expect that
openening a wallet mean creating a new alpha sorted list of _Open wallets_
at top of same list.

There's as much logic why loaded wallet should be first than why capital
letters wallet should be above lowercase ones when almost nobody has enough
wallets to care to sort them in any orders and actually might expect and
prefer previous sorting behavior of last opened goes up top, again, as long
as this reodering only happen at load and doesn't appear to insta-switch as
they open a 2nd one.

On Wed., Apr. 8, 2020, 05:14 Max Hillebrand, [e-mail]
wrote:

IMO either wallets should stay where they are and just open up or they
should get from the top down in the order they were opened.

What do you mean?
A wallet cannot be "closed" / unloaded, only the drop down menu of the
functions can be collapsed...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zkSNACKs/WalletWasabi/issues/3510#issuecomment-610847006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC643COOKVGUI466V37O33RLQ6AHANCNFSM4MDLIIDQ
.

[MaxHillebrand]

I agree that it might be better to not move the wallets at all, simply keeping them sorted alphabetically regardless if they are loaded or not. However, this might be an issue if a user has many many wallets, such that there is a scrollbar of wallets, and only a couple of them loaded. In this case, he will have to search through the long list to find open wallets. If contrarily the open wallets are up top, regardless of how many closed wallets there are, it is always easy to find the open ones.

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.